Repository navigation
fix(docs): restore 48px favicon and apple-touch-icon links - #4719
Conversation
|
@worktrunk-bot Please correct the Google Search diagnosis before this PR merges. Google's favicon guidance accepts a square icon at least 8×8, recommends one larger than 48×48, and supports Restoring the metadata may still be useful. Please revise the comments in
|
…rch fix Google's favicon guidance accepts any square icon of at least 8x8 and supports shortcut icon, so the 32x32 icon was not inherently ineligible.
|
Corrected in 1e3ec2a. The code comments now say the I rewrote the PR description the same way and dropped "for Google Search" from the title. I also changed |
The Astro rebuild (#3866) moved
favicon-48.pngandapple-touch-icon.pngintodocs/public/but dropped the<link>tags that #627 had added to the old Zola base template. Since then every page emits only<link rel="shortcut icon" href="/favicon.png">(32×32). This PR adds the two links back through Starlight'sheadoption, so the larger icons are discoverable again.This restores metadata. It doesn't fix the generic globe in Google Search (#4718), because nothing establishes the cause. Google's favicon guidance accepts a square icon of at least 8×8 and supports
shortcut icon, so the existing 32×32 icon is not inherently ineligible. Advertising a 48×48 icon follows Google's recommendation for a larger size, but whether it changes the search result is unverified.A new
built-site.test.mjscase requires both links on every rendered page, so they can't drop out silently again. It fails on the current build and passes with this change.npm run check,npm test, and the rest oftest:sitepass locally. The exception is the existing social-card asset check, which needs theworktrunk-assetsclone that CI fetches and this sandbox doesn't have.Refs #4718 — automated triage