Skip to content

fix(docs): restore 48px favicon and apple-touch-icon links - #4719

Merged
max-sixty merged 2 commits into
mainfrom
fix/issue-4718
Nov 6, 2026
Merged

max-sixty merged 2 commits into
mainfrom
fix/issue-4718

Conversation

@worktrunk-bot

@worktrunk-bot worktrunk-bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

The Astro rebuild (#3866) moved favicon-48.png and apple-touch-icon.png into docs/public/ but dropped the <link> tags that #627 had added to the old Zola base template. Since then every page emits only <link rel="shortcut icon" href="/favicon.png"> (32×32). This PR adds the two links back through Starlight's head option, so the larger icons are discoverable again.

This restores metadata. It doesn't fix the generic globe in Google Search (#4718), because nothing establishes the cause. Google's favicon guidance accepts a square icon of at least 8×8 and supports shortcut icon, so the existing 32×32 icon is not inherently ineligible. Advertising a 48×48 icon follows Google's recommendation for a larger size, but whether it changes the search result is unverified.

A new built-site.test.mjs case requires both links on every rendered page, so they can't drop out silently again. It fails on the current build and passes with this change. npm run check, npm test, and the rest of test:site pass locally. The exception is the existing social-card asset check, which needs the worktrunk-assets clone that CI fetches and this sandbox doesn't have.

Refs #4718 — automated triage

The Astro rebuild (#3866) kept favicon-48.png and apple-touch-icon.png in
public/ but dropped the <link> tags the Zola base template had for them, so
pages only advertise the 32x32 favicon. Google Search requires a favicon
sized in multiples of 48px and shows a generic globe otherwise.

Closes #4718
@worktrunk-bot worktrunk-bot added the automated-fix Automated CI fix label Nov 6, 2026
@max-sixty

Copy link
Copy Markdown
Owner

@worktrunk-bot Please correct the Google Search diagnosis before this PR merges. Google's favicon guidance accepts a square icon at least 8×8, recommends one larger than 48×48, and supports shortcut icon. The existing 32×32 shortcut icon is therefore not inherently ineligible, and the generic globe's cause is not established by this change.

Restoring the metadata may still be useful. Please revise the comments in docs/astro.config.mjs and docs/tests/built-site.test.mjs, and the PR description, to state what the change restores and frame the test as preserving those links without claiming a verified Search fix.

This was written by Codex on behalf of max-sixty

…rch fix

Google's favicon guidance accepts any square icon of at least 8x8 and
supports shortcut icon, so the 32x32 icon was not inherently ineligible.
@worktrunk-bot worktrunk-bot changed the title fix(docs): restore 48px favicon link for Google Search fix(docs): restore 48px favicon and apple-touch-icon links Nov 6, 2026
@worktrunk-bot

Copy link
Copy Markdown
Collaborator Author

Corrected in 1e3ec2a. The code comments now say the head entries restore the icon links from the Zola site (#627), because Starlight's favicon option emits only the 32×32 shortcut icon. I also renamed the test to built pages link the 48px favicon and apple-touch-icon, and it now describes itself as keeping those links. Neither one claims anything about Search eligibility anymore.

I rewrote the PR description the same way and dropped "for Google Search" from the title. I also changed Closes #4718 to Refs #4718: this change doesn't establish a fix for the globe, so merging it shouldn't close the issue.

@max-sixty
max-sixty merged commit 1a40681 into main Nov 6, 2026
36 checks passed
@max-sixty
max-sixty deleted the fix/issue-4718 branch November 6, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated-fix Automated CI fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants