Skip to content

Commit

Permalink
Merge pull request #234 from maxmind/greg/eng-1001-mark-metro-code-da…
Browse files Browse the repository at this point in the history
…ta-as-deprecated-in-our-libraries

Deprecate metro code
  • Loading branch information
horgh authored Jan 13, 2025
2 parents aa4cf39 + ce3406e commit 3ed5fca
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 5 deletions.
8 changes: 7 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
CHANGELOG
=========

3.2.0
------------------

* `metroCode` on `GeoIp2\Record\Location` has been deprecated. The code
values are no longer being maintained.

3.1.0 (2024-11-15)
------------------

Expand All @@ -15,7 +21,7 @@ CHANGELOG
* IMPORTANT: PHP 8.1 or greater is now required.
* BREAKING: Read-only properties are now used for the model and record
classes rather than magic methods. This significantly improves performance.
* BREAKING: The `raw` property on model classess and the `record` property on
* BREAKING: The `raw` property on model classes and the `record` property on
record classes have been removed.
* BREAKING: On `GeoIp2\Record\Traits`, the deprecated `isAnonymousProxy` and
`isSatelliteProvider` properties have been removed.
Expand Down
8 changes: 4 additions & 4 deletions src/Record/Location.php
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ class Location implements \JsonSerializable
public readonly ?float $longitude;

/**
* @var int|null The metro code of the location if the location
* is in the US. MaxMind returns the same metro codes as the
* Google AdWords API. See
* https://developers.google.com/adwords/api/docs/appendix/cities-DMAregions.
* @var int|null the metro code is a no-longer-maintained code for targeting
* advertisements in Google
*
* @deprecated
*/
public readonly ?int $metroCode;

Expand Down

0 comments on commit 3ed5fca

Please sign in to comment.