Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Multi-phase extension module initialization PEP489 #105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rcmcdonald91
Copy link
Contributor

@rcmcdonald91 rcmcdonald91 commented Jan 9, 2023

  • Adds support for PEP489.
  • Indirectly addresses a missing Py_INCREF that can cause segfaults when used by embedded interpreters.

@rcmcdonald91
Copy link
Contributor Author

rcmcdonald91 commented Jan 9, 2023

My first attempt at python extension work, I am addressing failing tests.

In the interim, I have created another PR #106 that directly addresses the missing Py_INCREF issue. #105 needs more work.

@rcmcdonald91
Copy link
Contributor Author

This likely requires a broader discussion on the minimum python version we want to support.

@oschwald
Copy link
Member

oschwald commented Jan 9, 2023

We generally support all Python versions that are still getting security updates upstream. That would mean that we will want to support 3.7 until June.

I haven't looked too closely at the code yet, but it would be fine to conditionally compile blocks of code for particular Python versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants