Makes LED client interface nullable for BGA167 #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 23, 2018 13:03
…of 10's of nanoseconds The mabs button and LED server was updating the LEDs every MIN_POLL_TIME_US reference clock ticks. But, the macro name implies that it should be updating the LEDs every MIN_POLL_TIME_US microseconds, rather than reference clock ticks. So, this fixes that. This also fixes an issue with the BGA167 boards where the MABS server is broken when the core clock is 500 MHz, because the timer is firing so rapidly it's never able to service any other events.
* astewart/master: Changed mabs timer to treat MIN_POLL_TIME_US as microseconds instead of 10's of nanoseconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're not using the LEDs on the baseboard, there's no point wasting a core for the server. Making the client nullable fixes this.