Skip to content

feat(Live.TripPlanner): wheelchair checkbox toggles groupings #2502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

thecristen
Copy link
Collaborator

@thecristen thecristen commented Apr 9, 2025

Asana Ticket: Trip Planner: group results based on newly fixed accessibility score (last task in TP | Update trip accessibility display)

Mainly UI changes here:

  • "Prefer accessible trips" is unchecked - show itinerary summaries grouped by "Accessible Routes" follow by "Inaccessible Routes"
  • "Prefer accessible trips" is checked - show itinerary summaries in a flat list (like now), limited only to those which are accessible (this was already done in feat(TripPlanner): filter itineraries if wheelchair: true set #2501)

Backend change:

Tip

Revised PR

Fixes some flawed assumptions, now has the following changes:

  • "Prefer accessible trips" is unchecked - show itinerary summaries in a flat list (like now)
  • "Prefer accessible trips" is checked - show itinerary summaries grouped by "Accessible Routes" followed by "Inaccessible Routes"
    No changes to how we make requests to OTP.

@thecristen thecristen added the dev-blue Deploy to dev-blue label Apr 9, 2025
@thecristen thecristen force-pushed the cbj/trip-planner-accessible branch from 6b65be4 to 7753efd Compare April 11, 2025 14:18
@thecristen thecristen removed the dev-blue Deploy to dev-blue label Apr 11, 2025
@thecristen thecristen changed the title wip: group itineraries by accessibility feat(Live.TripPlanner): wheelchair checkbox toggles groupings Apr 11, 2025
@thecristen thecristen marked this pull request as ready for review April 11, 2025 14:40
@thecristen thecristen requested a review from a team as a code owner April 11, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-blue Deploy to dev-blue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants