Fix: correct regexp parsing of Heroku PostgreSQL $DATABASE_URL#1
Open
BenedictHW wants to merge 1 commit intomck-:masterfrom
BenedictHW:fix-regexp
Open
Fix: correct regexp parsing of Heroku PostgreSQL $DATABASE_URL#1BenedictHW wants to merge 1 commit intomck-:masterfrom BenedictHW:fix-regexp
BenedictHW wants to merge 1 commit intomck-:masterfrom
BenedictHW:fix-regexp
Conversation
Heroku changed the $DATABASE_URL so the regexp needs updating. Just a ":" instead of a "/" will give the correct host. Otherwise you will get ec2-54-81-126-151.compute-1.amazonaws.com:5432 instead of ec2-54-81-126-151.compute-1.amazonaws.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Heroku changed the $DATABASE_URL so the regexp needs updating. Just a ":"
instead of a "/" will give the correct host. Otherwise you will get
ec2-54-81-126-151.compute-1.amazonaws.com:5432
instead of
ec2-54-81-126-151.compute-1.amazonaws.com