Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Enable dynamic DatePicker #1039

Merged
merged 14 commits into from
Mar 10, 2025
Merged

[Feat] Enable dynamic DatePicker #1039

merged 14 commits into from
Mar 10, 2025

Conversation

nadijagraca
Copy link
Contributor

@nadijagraca nadijagraca commented Feb 25, 2025

Description

This PR adds dynamic mode support for the DatePicker selector.

How to test:

There's data.yaml file that you can use to tweak the dynamic data that will be loaded. Here's its structure:

# Choose between: 2024-01-01 to 2024-05-29
date_min: 2024-03-05
date_max: 2024-03-10

After running the app, adjust date_min and date_max and these values will define the new min and max of the dynamic data after refreshing the apge.

P.S: The app is not intended to be tested with PyCafe as changing the data.yaml causes the entire app to rerun.

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

Copy link
Contributor

github-actions bot commented Feb 25, 2025

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2025-03-10 15:21:24 UTC
Commit: f02e33a

Compare the examples using the commit's wheel file vs the latest released version:

vizro-core/examples/scratch_dev

View with commit's wheel vs View with latest release

vizro-core/examples/dev/

View with commit's wheel vs View with latest release

vizro-core/examples/visual-vocabulary/

View with commit's wheel vs View with latest release

vizro-core/examples/tutorial/

View with commit's wheel vs View with latest release

vizro-ai/examples/dashboard_ui/

View with commit's wheel vs View with latest release

@petar-qb petar-qb self-requested a review February 25, 2025 16:55
@petar-qb petar-qb requested a review from stichbury as a code owner February 27, 2025 07:22
@petar-qb petar-qb self-assigned this Feb 27, 2025
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a docs perspective, just one minor change which you can ignore if you want. I won't approve as most of this is not docs related, but from my perspective, it's all good 🌟

Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great but I'd like to understand the answer to my question before I continue reviewing 🙏

Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great, nice work @nadijagraca and @petar-qb!

It would be nice to have another pair of eyes to just do some quick manual testing too. I nominate @maxschulz-COL 😀

@petar-qb petar-qb changed the title [Dev] Enable dynamic DatePicker [Feat] Enable dynamic DatePicker Mar 4, 2025
Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ Tested it manually, and went though code. Looks good to me!

@petar-qb petar-qb merged commit 77c898b into main Mar 10, 2025
41 checks passed
@petar-qb petar-qb deleted the dev/dynamic-datepicker branch March 10, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants