-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Enable dynamic DatePicker #1039
Conversation
View the example dashboards of the current commit live on PyCafe ☕ 🚀Updated on: 2025-03-10 15:21:24 UTC Compare the examples using the commit's wheel file vs the latest released version: vizro-core/examples/scratch_devView with commit's wheel vs View with latest release vizro-core/examples/dev/View with commit's wheel vs View with latest release vizro-core/examples/visual-vocabulary/View with commit's wheel vs View with latest release vizro-core/examples/tutorial/View with commit's wheel vs View with latest release vizro-ai/examples/dashboard_ui/ |
…amic-datepicker
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a docs perspective, just one minor change which you can ignore if you want. I won't approve as most of this is not docs related, but from my perspective, it's all good 🌟
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great but I'd like to understand the answer to my question before I continue reviewing 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks great, nice work @nadijagraca and @petar-qb!
It would be nice to have another pair of eyes to just do some quick manual testing too. I nominate @maxschulz-COL 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ Tested it manually, and went though code. Looks good to me!
Description
This PR adds dynamic mode support for the DatePicker selector.
How to test:
There's
data.yaml
file that you can use to tweak the dynamic data that will be loaded. Here's its structure:After running the app, adjust
date_min
anddate_max
and these values will define the newmin
andmax
of the dynamic data after refreshing the apge.P.S: The app is not intended to be tested with PyCafe as changing the
data.yaml
causes the entire app to rerun.Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":