Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Change light theme #1048

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Mar 4, 2025

Description

  • Switch out background color for left side and right side in light theme, such that filled container color is white on light theme

If we were to implement this change - this is the default:
Charts on a light grey background
Screenshot 2025-03-04 at 23 09 59

Change needed - card colors need to change to white, otherwise they blend in with the new background
Screenshot 2025-03-04 at 23 09 17

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

@huong-li-nguyen huong-li-nguyen changed the base branch from main to tidy/add-minor-visual-changes March 4, 2025 22:12
Comment on lines +21 to +22
--right-side-bg: var(--surfaces-bg02);
--left-side-bg: var(--surfaces-bg01);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Joseph-Perkins - this would be the only change required in terms of CSS now to switch out the bg colors from the outer and inner containers.

I'll comment on the issues in the PR so we can come back to it if we want

Copy link
Contributor

github-actions bot commented Mar 4, 2025

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2025-03-04 22:14:13 UTC
Commit: 63faa94

Compare the examples using the commit's wheel file vs the latest released version:

vizro-core/examples/scratch_dev

View with commit's wheel vs View with latest release

vizro-core/examples/dev/

View with commit's wheel vs View with latest release

vizro-core/examples/visual-vocabulary/

View with commit's wheel vs View with latest release

vizro-ai/examples/dashboard_ui/

View with commit's wheel vs View with latest release

@huong-li-nguyen huong-li-nguyen self-assigned this Mar 5, 2025
Base automatically changed from tidy/add-minor-visual-changes to main March 6, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant