[Feat] Add plain text component #1061
Conversation
nadijagraca
requested review from
Joseph-Perkins,
antonymilne,
huong-li-nguyen,
maxschulz-COL and
lingyielia
as code owners
View the example dashboards of the current commit live on PyCafe ☕ 🚀Updated on: 2025-03-11 13:34:04 UTC Compare the examples using the commit's wheel file vs the latest released version: vizro-core/examples/scratch_devView with commit's wheel vs View with latest release vizro-core/examples/dev/View with commit's wheel vs View with latest release vizro-core/examples/visual-vocabulary/View with commit's wheel vs View with latest release vizro-core/examples/tutorial/View with commit's wheel vs View with latest release vizro-ai/examples/dashboard_ui/ |
There was a problem hiding this comment.
Very clean! Congrats @nadijagraca 🚀
I have a few comments, but this PR looks great in general.
| <!-- | ||
| ### Added | ||
|
|
||
| - A bullet item for the Added category with a link to the relevant PR at the end of your entry, e.g. Enable feature XXX. ([#1](https://github.com/mckinsey/vizro/pull/1)) |
| ("""# Header""", "# Header"), | ||
| ("""_This **tests** emphasis_""", "_This **tests** emphasis_"), | ||
| ("""> This tests blockquotes""", "> This tests blockquotes"), | ||
| ("""* This tests list items""", "* This tests list items"), | ||
| ("Text to test card", "Text to test card"), | ||
| ("", ""), | ||
| ( | ||
| """""", | ||
| "", | ||
| ), | ||
| ("""Code block: ```python print(1)```""", "Code block: ```python print(1)```"), | ||
| ("""[Example page](/test_page)""", "[Example page](/test_page)"), |
There was a problem hiding this comment.
Is there any difference between test_text and expected?
There was a problem hiding this comment.
Good question. Ar we trying to test various situation where it might be altered but isn't?
There was a problem hiding this comment.
Yes, this tests that Markdown does not modify the input string.
| from vizro.models._models_utils import _log_call | ||
|
|
||
|
|
||
| class Markdown(VizroBaseModel): |
There was a problem hiding this comment.
@antonymilne Do we really want to call the model Markdown? Wouldn't vm.Text be more declarative?
| ("""# Header""", "# Header"), | ||
| ("""_This **tests** emphasis_""", "_This **tests** emphasis_"), | ||
| ("""> This tests blockquotes""", "> This tests blockquotes"), | ||
| ("""* This tests list items""", "* This tests list items"), | ||
| ("Text to test card", "Text to test card"), | ||
| ("", ""), | ||
| ( | ||
| """""", | ||
| "", | ||
| ), | ||
| ("""Code block: ```python print(1)```""", "Code block: ```python print(1)```"), | ||
| ("""[Example page](/test_page)""", "[Example page](/test_page)"), |
There was a problem hiding this comment.
Good question. Ar we trying to test various situation where it might be altered but isn't?
Description
Added a new
vm.Markdownmodel, allowing users to add plain text to their dashboard layout.Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":