Skip to content

Init mcpp start - #1

Merged
Sunrisepeak merged 4 commits into
mainfrom
init_mcpp_start
Feb 4, 2026
Merged

Sunrisepeak merged 4 commits into
mainfrom
init_mcpp_start

Conversation

@Sunrisepeak

Copy link
Copy Markdown
Member

@Sunrisepeak
Sunrisepeak requested a review from MoYingJi February 4, 2026 17:33
Copilot AI review requested due to automatic review settings February 4, 2026 17:39
@Sunrisepeak
Sunrisepeak merged commit 7fdb58a into main Feb 4, 2026
@Sunrisepeak
Sunrisepeak deleted the init_mcpp_start branch February 4, 2026 17:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR initializes a new project called "mcpp-start" (Modern C++ Start with import std) by adapting from a d2x project template. The changes transform a generic template into a specific project focused on modern C++ features, particularly C++23 modules.

Changes:

  • Removed template-specific documentation and example code (hellocpp.cpp, chapter_2.md, chapter_3.md)
  • Updated project branding and metadata (README, LICENSE, chapter_0.md) to reflect mcpp-start identity
  • Restructured build configuration for modern C++ modules (xmake.lua changes)

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
LICENSE Added mcpp community copyright alongside d2learn
README.md Updated project title, description, and contact information for mcpp-start
book/src/SUMMARY.md Restructured table of contents, removed template chapters
book/src/chapter_0.md Changed introduction from template to mcpp-start project
book/src/chapter_1.md Updated installation instructions for mcpp-start project
book/src/chapter_2.md Removed template configuration documentation
book/src/chapter_3.md Removed placeholder chapter
book/src/other/chapter_0.md Added new "Contributing" section
dslings/hellocpp.cpp Removed template example code
dslings/xmake.lua Restructured build configuration for mcpp module

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread book/src/chapter_1.md
# 工具安装与环境配置

本章节介绍如果安装d2x工具并创建模板项目, 以及基础的环境配置
本章节介绍如果安装d2x工具并获取项目

Copilot AI Feb 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: "如果" (if) should be "如何" (how). The sentence should read "本章节介绍如何安装d2x工具并获取项目" (This chapter introduces how to install the d2x tool and obtain the project).

Suggested change
本章节介绍如果安装d2x工具并获取项目
本章节介绍如何安装d2x工具并获取项目

Copilot uses AI. Check for mistakes.
Comment thread dslings/xmake.lua
@@ -1,9 +1,5 @@
target("hellocpp")
add_files("hellocpp.cpp")
add_files("../d2x/mcpp/d2x.cppm")

Copilot AI Feb 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The add_files call on line 1 is outside any target definition. In xmake.lua, add_files should be called within a target() scope. This orphaned add_files call may not work as intended. Consider moving it inside the "hellomcpp" target or creating a separate target for it.

Copilot uses AI. Check for mistakes.
Comment thread book/src/chapter_0.md
Comment on lines 9 to 11
| [d2x工具](https://github.com/d2learn/d2x) - [论坛](https://forum.d2learn.org) |
| --- |
| [文档](https://d2learn.github.io/d2x-project-template) -> [工具和环境配置](https://d2learn.github.io/d2x-project-template/chapter_1.html) -> [项目和新内容添加](https://d2learn.github.io/d2x-project-template/chapter_2.html) |

Copilot AI Feb 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent forum URLs between README.md and chapter_0.md. README.md uses "https://mcpp.d2learn.org/forum" while chapter_0.md uses "https://forum.d2learn.org". Additionally, the documentation links in chapter_0.md still point to the old template repository "d2learn.github.io/d2x-project-template" instead of the new project. These should be updated for consistency.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants