openkal-musl 0.9.0 - #286
Merged
Merged
Conversation
A build can state which version of this library it holds. `uname`'s release field was the string literal "0.5.0" through every release after 0.5.0, so a program that asked was given a false answer rather than none. It now comes from the manifest, and `OPENKAL_MUSL_TRACE=enosys` names the version before the program runs whether or not anything is missing --- the absence of which had two rounds of mcpplibs/openkal-linux#13 answered against the wrong version. Nothing changes for a program that does not ask: with the variable unset the library writes zero bytes to the error stream, asserted on every row. Measured before this commit: the CN mirror asset returns 200, opens as an archive, and its sha256 is identical to the GitHub tag tarball.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A build can state which version of this library it holds.
uname'sreleasefield was the string literal"0.5.0"through every release after 0.5.0 — a false answer rather than a missing one, which is the worse of the two, because a consumer who checked it was misled rather than left uncertain. Two rounds of mcpplibs/openkal-linux#13 were answered against the wrong version because of it.Printed before the program runs and whether or not anything is missing. Previously a run in which nothing was refused printed nothing at all, so "the version is right and nothing is absent", "the variable did not take effect" and "this is not the binary I think it is" were one reading.
The number is read from
mcpp.tomlbybuild.mcpprather than written out a second time, and the workflow compares the printed line against the manifest.Nothing changes for a program that does not ask: with the variable unset the library writes zero bytes to the error stream, asserted on every row of the matrix precisely so this cannot become noise in an ordinary run.
Measured
Fetched back from the published CN URL, hashed against the GitHub tag tarball, and opened as an archive — the check that caught a fourteen-byte
404: Not Foundon the previous entry (#284).Locally:
check_mirror_urls,check_package_name,check_cross_package_refs,check_platform_version_parity,check_duplicate_versionsall pass. Added to all three platform tables.