0.4.0 --- follow openkal 0.10 - #10
Merged
Merged
Conversation
⚠️ A REPIN AND NOTHING ELSE, AND IT IS NOT OPTIONAL. openkal 0.10 adds five declarations, all of them to interfaces this implementation does not provide --- so nothing here has anything to implement. What is not optional is the version. A version requirement in this ecosystem is EXACT and does not float up, and `openkal' is the shared dependency of every package in the graph. An implementation left at 0.9.0 while a consumer moves to 0.10.0 does not get its own older contract: the two are irreconcilable and nothing resolves at all. So a specification revision moves the whole graph or none of it, and this package is part of the graph.
Same defect as openkal-opensbi and found the same way: the commit is titled 0.4.0, moves the openkal requirement to 0.10.0, and left `version' at 0.3.0. A release tagged 0.4.0 whose manifest says 0.3.0 is a package that does not answer to its own name. Checked every self-version in the chain against what its consumers require. These two were the only ones that disagreed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the openkal 0.10 move: mcpplibs/openkal#25.
openkalisthe shared dependency of every package here and a version requirement is exact —
an implementation left at 0.9.0 while a consumer moves to 0.10.0 does not get its
own older contract; the two are irreconcilable and nothing resolves at all.
Branch
declarations-0.10exists in every implementation so the specification'sown cross-repository job builds against this one.
The commit message states what this package does with each of the five new
declarations and why.