-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update support data for Chrome Android #17908
Conversation
These changes were generated procedurally by the mdn-bcd-collector project using data collected from Chrome for Android and following three corrections to its interpretation of the "mirror" support value: foolip/mdn-bcd-collector#2326 foolip/mdn-bcd-collector#2297 foolip/mdn-bcd-collector#2280
The commit "Rename XR interface to XRSystem" was released in version 83: https://chromiumdash.appspot.com/commit/d7a0292ca39f93d358b68ee703b0eb4fb4901022 The commit "Enable drag and drop on Android platform by default" was released in version 54: https://chromereleases.googleblog.com/2016/10/chrome-for-android-update.html
The mdn-bcd-collector tool has a deficiency which cause it to produce incorrect changes for the Notification constructor. See "Testing constructors with no arguments misses some ways of disabling constructors": foolip/mdn-bcd-collector#970
@foolip @queengooborg This patch has been rejected in CI due to 15 instances where a sub-feature is labeled as "supported" while its parent is not. For instance:
However, that change is consistent with the data in mdn-bcd-results:
This makes me suspect that there may be a problem with the tests themselves. Reviewing the code generated by mdn-bcd-collector, it looks like the test for |
This sort of thing happens when there are custom tests that aren't quite right. Looking at https://mdn-bcd-collector.appspot.com/tests/api/AudioProcessingEvent it seems like the problem is that the |
@@ -49,7 +49,9 @@ | |||
"chrome": { | |||
"version_added": "56" | |||
}, | |||
"chrome_android": "mirror", | |||
"chrome_android": { | |||
"version_added": false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parent feature has flag data, so I think this might be a case of #6509. In one way of interpreting the previous data it means that the AmbientLightSensor
constructor was supported in Chrome Android 56, behind a flag. (The other interpretation would say the data is inconsistent.)
Got it. Here's a patch to fix that. |
The other errors concern the PermissionsPolicyViolationReportBody and a few APIs in SpeechSynthesis. It seems like we'll need to address them all before we can land this. I'll start with the former for now:
The It looks like MDN has good reason to document these, anyway: the Is this a case for a custom IDL file in mdn-bcd-collector? |
Oh my, the incomplete Feature Policy → Permissions Policy rename again. cc @clelland I added custom tests in foolip/mdn-bcd-collector#2406, but Chromium has @jugglinmike I'd suggest just backing out any changes to |
Due to known issues in the tooling, the automatically-generated changes to `api/PermissionsPolicyViolationReportBody.json` were inaccurate and needed to be manually removed. mdn#17908 (comment)
cb060b3
to
cb21fb9
Compare
Thanks, @foolip! I've manually reverted those changes as you suggested. Moving on the final batch of errors, it appears that (similar to the AudioProcessingEvent) the mdn-bcd-collector project also has deficiencies in its custom tests for the Speech Synthesis API proposal. In this case, though, it looks like some normative changes might be in order. |
I've fixed custom tests and deployed again, so these tests now look better: |
This pull request has merge conflicts that must be resolved before it can be merged. |
This PR is quite large and touches on many different interfaces. Could we split this off into smaller chunks for easier review and merging? |
Re: PermissionsPolicyViolationReportBody; that shouldn't be listed as supported anywhere; it was in an origin trial (as FeaturePolicyViolationReportBody) between Chrome 73 and 75, but hasn't been shipped. |
Due to known issues in the tooling, the automatically-generated changes to `api/PermissionsPolicyViolationReportBody.json` were inaccurate and needed to be manually removed. mdn#17908 (comment)
@queengooborg Sure. I've factored this changeset into four parts:
Together, those supersede this patch, so I'll close this one. |
Summary
The changes in the first commit were generated procedurally by the mdn-bcd-collector project using data collected from Chrome for Android and following three corrections to its interpretation of the "mirror" support value:
foolip/mdn-bcd-collector#2326
foolip/mdn-bcd-collector#2297
foolip/mdn-bcd-collector#2280
Test results and supporting details
The modifications in the second commit were made manually.
The Chromium commit "Rename XR interface to XRSystem" was released in version 83:
https://chromiumdash.appspot.com/commit/d7a0292ca39f93d358b68ee703b0eb4fb4901022
The Chromium commit "Enable drag and drop on Android platform by default" was released in version 54:
https://chromereleases.googleblog.com/2016/10/chrome-for-android-update.html
Related issues
The modifications in the third commit were made manually.
The mdn-bcd-collector tool has a deficiency which cause it to produce incorrect changes for the Notification constructor. See "Testing constructors with no arguments misses some ways of disabling constructors": foolip/mdn-bcd-collector#970