-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mdn-bcd-collector update script #19971
Merged
+3,591
−6
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
8f69526
add update script from mdn-bcd-collector
mzgoddard c10c320
copy libs used by update from mdn-bcd-collector
mzgoddard 419ead2
add depedencies
mzgoddard 16901b3
bump package-lock
mzgoddard 900b335
fixup! add update script from mdn-bcd-collector
mzgoddard 05aba08
fixup! add update script from mdn-bcd-collector
mzgoddard 5548e4d
fixup! copy libs used by update from mdn-bcd-collector
mzgoddard a598080
fixup! add update script from mdn-bcd-collector
mzgoddard 5bad98a
Merge branch 'main' into update-script
mzgoddard 7f34348
fixup! add update script from mdn-bcd-collector
mzgoddard e9f7ed8
fixup! copy libs used by update from mdn-bcd-collector
mzgoddard 4298b94
fixup! add update script from mdn-bcd-collector
mzgoddard 2638dc1
fixup! add update script from mdn-bcd-collector
mzgoddard b45eb0d
fixup! add depedencies
mzgoddard 01659c5
fixup! bump package-lock
mzgoddard 3e6f299
fixup! copy libs used by update from mdn-bcd-collector
mzgoddard 4bcd8aa
fixup! add depedencies
mzgoddard 8502ef5
fixup! bump package-lock
mzgoddard ed9c69c
fixup! add update script from mdn-bcd-collector
mzgoddard 270f6f7
fixup! add depedencies
mzgoddard f50b806
fixup! bump package-lock
mzgoddard f7e81da
fixup! add update script from mdn-bcd-collector
mzgoddard 01d215b
add update script tests
mzgoddard cbd5d11
fixup! add depedencies
mzgoddard 4279091
fixup! bump package-lock
mzgoddard 2480535
fixup! add depedencies
mzgoddard 656d320
fixup! bump package-lock
mzgoddard 3035362
Merge branch 'main' into update-script
mzgoddard e3d9982
Merge branch 'main' into update-script
mzgoddard a321360
depend on minimatch@5 for update script
mzgoddard 850c030
bump package-lock.json
mzgoddard b601c39
Merge branch 'main' into update-script
mzgoddard 92d671b
Merge branch 'main' into update-script
mzgoddard bbbe907
Merge branch 'main' into update-script
mzgoddard 8794197
fixup! bump package-lock.json
mzgoddard a78bfd3
Merge branch 'main' into update-script
mzgoddard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fixup! add depedencies
commit b45eb0d0a3e8efe73fb764b7da8e905e7eeeab18
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is only used for
fs.readJson()
. Can you get rid of it and just use plain fs andJSON.parse()
like other existing code in BCD?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of this I'm going to make reading the json files serial like what is done in
index.ts
.update
at the moment reads the json in parallel. Since it is as of this time 1455 json files, some systems may run in EMFILE or ENFILE errors opening that many files at one time.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, I guess @queengooborg and I never ran into that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mzgoddard the fs-extra dependency is still here. Can it be removed now?