Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document limitations of performance.getEntries* methods #22841

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Dec 9, 2022

Description

Fix #22619. I've expanded the notebox to mention this limitation. Hopefully this will lead to even more encouragement to prefer PerformanceObserver objects.

Motivation

openwebdocs/project#62

Additional details

None.

Related issues and pull requests

None.

@Elchi3 Elchi3 requested a review from a team as a code owner December 9, 2022 13:56
@Elchi3 Elchi3 requested review from wbamberg and removed request for a team December 9, 2022 13:56
@github-actions github-actions bot added the Content:WebAPI Web API docs label Dec 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2022

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine but I would not have it in a note. It's just part of the API behavior. But then I am a note minimalist, so up to you.

sideshowbarker
sideshowbarker previously approved these changes Dec 11, 2022
@sideshowbarker sideshowbarker dismissed their stale review December 11, 2022 07:51

Didn’t see Will’s comment…

@Elchi3
Copy link
Member Author

Elchi3 commented Dec 12, 2022

Since I got no approval, I moved the text outside the note.

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you Florian.

@wbamberg wbamberg merged commit 7938403 into mdn:main Dec 12, 2022
@Elchi3 Elchi3 deleted the limitations-getEntries branch December 12, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

performance.getEntries[*] does not return all entry types
3 participants