-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coop noopener allow popups #36232
Coop noopener allow popups #36232
Conversation
Preview URLs
External URLs (4)URL:
URL:
URL:
URL:
(comment last updated: 2024-11-12 07:02:27) |
a740be8
to
53ada62
Compare
53ada62
to
4ada6ca
Compare
Apologies, but I botched the commit history on this PR. I think it would be squashed away at merge time, but let me know if that's not the case, and I'll create a new PR instead of this one. |
4ada6ca
to
062857f
Compare
files/en-us/web/http/headers/cross-origin-opener-policy/index.md
Outdated
Show resolved
Hide resolved
@yoavweiss Thanks for this. Can you create an update to the browser compatibility data for this? We document things that are released, and I suspect it will be a lot easier for you to work out the version of chrome that support this than me. I tidied the commit history by dropping the commits that didn't make sense. Squash probably would have worked. IMO this is not quite sufficient. Specifically I don't think that someone can use this and understand what it is for without reading the spec and the explainer. Further, I think that was true before you made these changes. Consider:
What's a browsing context group and who cares if they share a cross-origin document? To fix this:
Does that make sense? |
Thanks @hamishwillee ! This makes perfect sense.
I found an explainer that outlines that. Should this be part of this PR? Or a separate one to improve COOP docs in general? |
BCD PR: mdn/browser-compat-data#24660 |
@yoavweiss FYI back on Friday and will look at this then. Would be good to fix the whole doc in one go :-) |
files/en-us/web/http/headers/cross-origin-opener-policy/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/http/headers/cross-origin-opener-policy/index.md
Outdated
Show resolved
Hide resolved
Thanks @yoavweiss . I've read the explainers. I hope you can answer my inline questions. A few other things to confirm:
Thoughts? Depending on your answer/answers to some of this we might merge the initial changes and then com back to this. I would like to see an example for this particular case though, because right now it is a little "abstract", and what you put in the explainer makes it a bit more real. |
Again, I'd love @camillelamy to make sure I get it right..
That practically translates to top-level documents that need to maintain the ability to script each other ("retain references").
I don't believe that's correct, but it's not obvious to me what you're referring to as "window" here (given "tabs"). A browsing context group is a set of top-level documents. ("tabs" % fenced frames, I think) Popups can be in the same group, depending the results of the BCG check I think new tabs create a new group.
Yes
The benefits are that the different documents can be process isolated, as they don't have to be able to script each other. Cutting off the ability of them to be able to script each other also has security benefits beyond process isolation.
Potentially. It may be good to provide a high-level summary there and link here.
I think that makes sense. |
files/en-us/web/http/headers/cross-origin-opener-policy/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/http/headers/cross-origin-opener-policy/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Hamish Willee <[email protected]>
68e366e
to
9692444
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yoavweiss Thanks very much. Following your response on matching this all makes a lot more sense.
I have updated the directives and also added in tables, because I think they do make this a lot more clear: https://pr36232.content.dev.mdn.mozit.cloud/en-US/docs/Web/HTTP/Headers/Cross-Origin-Opener-Policy#description
I have approved and am happy to merge (will do a reread tomorrow). Leaving open for you to check if you wish though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % a contradiction on same-origin-allow-popups
files/en-us/web/http/headers/cross-origin-opener-policy/index.md
Outdated
Show resolved
Hide resolved
Thanks @yoavweiss for your many reviews and patience. FWIW I think this is a much more usable document than what it replaces. It should also be much easier to update when/if there are further additions. |
Thank you!! |
Description
Added the new
noopener-allow-popup
COOP valueMotivation
To inform developers of this new header value.
Additional details
Related issues and pull requests
Fixes mdn/mdn#579
Related to whatwg/html#10394