Final batch of Temporal edits #38092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:JS
Josh-Cena
reviewed
Feb 11, 2025
files/en-us/web/javascript/reference/global_objects/temporal/instant/subtract/index.md
Outdated
Show resolved
Hide resolved
Josh-Cena
reviewed
Feb 11, 2025
files/en-us/web/javascript/reference/global_objects/temporal/plaindate/month/index.md
Outdated
Show resolved
Hide resolved
Most likely, the time zone annotation is appended if you are logging a ZonedDateTime object.
I found it difficult to understand what the code example was showing because it mentioned a day example but it wasn't clear where this example was. I think it's clearer with a link. (I split the code block in two and moved the sentence outside of the code block so that I could put a link in it.)
ptomato
force-pushed
the
temporal-edits
branch
from
d6681a8 to
b14b21f
Compare
Josh-Cena
approved these changes
Feb 11, 2025
ya01in
pushed a commit
to ya01in/content
that referenced
this pull request
Feb 11, 2025
* Fix broken links * Note RangeError thrown by disambiguation: "reject" when wall-clock time is ambiguous * Fix log output of ZonedDateTime Most likely, the time zone annotation is appended if you are logging a ZonedDateTime object. * Fix copy-paste error * Add link to "day example" I found it difficult to understand what the code example was showing because it mentioned a day example but it wasn't clear where this example was. I think it's clearer with a link. (I split the code block in two and moved the sentence outside of the code block so that I could put a link in it.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A couple of minor edits to the Temporal docs: a few clarifications and typo fixes.
Motivation
I've finished reading through the original docs PR of Temporal and this is the last batch of edits that came to mind while reading it. Thanks for all the hard work on documenting it!
Additional details
Related issues and pull requests
Relates to #37344, #37905, and #37978