Skip to content

Remove unreferenced images #39026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove unreferenced images #39026

wants to merge 1 commit into from

Conversation

Josh-Cena
Copy link
Member

Discovered by my new automation.

To review this, you probably need to search through the entire content to confirm that these files are not referenced anywhere.

@Josh-Cena Josh-Cena requested a review from bsmth April 7, 2025 22:57
@Josh-Cena Josh-Cena requested review from a team as code owners April 7, 2025 22:57
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs Content:Learn Learning area docs Content:Games Games docs Content:Meta Content in the meta docs labels Apr 7, 2025
@Josh-Cena Josh-Cena removed request for a team April 7, 2025 22:57
@github-actions github-actions bot added the size/xs [PR only] 0-5 LoC changed label Apr 7, 2025
@bsmth
Copy link
Member

bsmth commented Apr 8, 2025

you probably need to search through the entire content to confirm that these files are not referenced anywhere.

I did this and didn't find them referenced via relative links in en-US. The problem is that these are used in translated-content:

../translated-content/files/ja/web/api/window/confirm/index.md:![Firefox の confirm](firefox_confirm_dialog.png)
../translated-content/files/ru/web/api/window/confirm/index.md:![firefox confirm](firefox_confirm_dialog.png)
../translated-content/files/zh-cn/web/api/window/confirm/index.md:![Firefox 确认对话框](firefox_confirm_dialog.png)
../translated-content/files/pt-br/web/api/window/confirm/index.md:![firefox confirm](firefox_confirm_dialog.png)
../translated-content/files/ko/web/api/window/confirm/index.md:![firefox confirm](firefox_confirm_dialog.png)
../translated-content/files/es/web/api/window/confirm/index.md:![Firefox confirm](firefox_confirm_dialog.png)
// etc.

There are only a few that are unused in all locales, as far as I see:

cube-playcanvas.png
playcanvas-github.png
shapes-playcanvas.png
flexbox-example6.png

I think safely removing the others is blocked on doc updates in the translated content repo or the images will break, as far as I understand.

@Josh-Cena
Copy link
Member Author

Josh-Cena commented Apr 8, 2025

I'm not sure about that because my own habit is to remove images whenever they are unused in our content—I'm fairly sure some others do that too. I think it's a bit of a hassle to have to care about translated content when maintaining the main content, and any out-of-sync should be a bug in itself, even without a broken image, so I'd argue that those pages are already broken as-is. This PR just performs cleanup that ought to have happened with the content change.

@bsmth
Copy link
Member

bsmth commented Apr 11, 2025

@mdn/localization-team-leads FYI there is some cleanup incoming here - could you please take a look at the removals and try to plan for these deletions so you don't have broken images in downstream pages?

@bsmth
Copy link
Member

bsmth commented Apr 11, 2025

I'm not sure about that because my own habit is to remove images whenever they are unused in our content—I'm fairly sure some others do that too. I think it's a bit of a hassle to have to care about translated content when maintaining the main content, and any out-of-sync should be a bug in itself, even without a broken image, so I'd argue that those pages are already broken as-is. This PR just performs cleanup that ought to have happened with the content change.

I understand, yes. Basically, I'm +1 on the changes, but I'd like to give the translated content teams some time to react before we remove them, how does that sound?

@Josh-Cena
Copy link
Member Author

Yeah sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs Content:Games Games docs Content:Learn Learning area docs Content:Meta Content in the meta docs Content:WebAPI Web API docs size/xs [PR only] 0-5 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants