-
Notifications
You must be signed in to change notification settings - Fork 22.7k
Remove unreferenced images #39026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Remove unreferenced images #39026
Conversation
I did this and didn't find them referenced via relative links in en-US. The problem is that these are used in translated-content:
There are only a few that are unused in all locales, as far as I see:
I think safely removing the others is blocked on doc updates in the translated content repo or the images will break, as far as I understand. |
I'm not sure about that because my own habit is to remove images whenever they are unused in our content—I'm fairly sure some others do that too. I think it's a bit of a hassle to have to care about translated content when maintaining the main content, and any out-of-sync should be a bug in itself, even without a broken image, so I'd argue that those pages are already broken as-is. This PR just performs cleanup that ought to have happened with the content change. |
@mdn/localization-team-leads FYI there is some cleanup incoming here - could you please take a look at the removals and try to plan for these deletions so you don't have broken images in downstream pages? |
I understand, yes. Basically, I'm +1 on the changes, but I'd like to give the translated content teams some time to react before we remove them, how does that sound? |
Yeah sure. |
Discovered by my new automation.
To review this, you probably need to search through the entire content to confirm that these files are not referenced anywhere.