Skip to content

Editorial review: Document NavigateEvent.sourceElement property #39068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Editorial review: Document NavigateEvent.sourceElement property #39068

wants to merge 2 commits into from
+51 −0

Conversation

chrisdavidmills
Copy link
Contributor

Description

The NavigateEvent.sourceElement property is supported in Chrome 135 — see https://chromestatus.com/feature/5134353390895104.

This PR provides documentation for the new property.

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested a review from a team as a code owner April 10, 2025 16:29
@chrisdavidmills chrisdavidmills requested review from wbamberg and removed request for a team April 10, 2025 16:29
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Apr 10, 2025
@chrisdavidmills chrisdavidmills changed the title Document NavigateEvent.sourceElement property Technical review: Document NavigateEvent.sourceElement property Apr 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 10, 2025 •
edited
Loading

Preview URLs

Flaws (9)

URL: /en-US/docs/Web/API/NavigateEvent
Title: NavigateEvent
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/a which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/area which is a redirect

URL: /en-US/docs/Web/API/NavigateEvent/NavigateEvent
Title: NavigateEvent: NavigateEvent() constructor
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/a which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/area which is a redirect

URL: /en-US/docs/Web/API/NavigateEvent/sourceElement
Title: NavigateEvent: sourceElement property
Flaw count: 5

  • broken_links:
    • /en-US/docs/Web/HTML/Element/input/submit is a redirect
    • /en-US/docs/Web/HTML/Element/button is a redirect
  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/a which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/area which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/form which is a redirect
External URLs (3)

URL: /en-US/docs/Web/API/NavigateEvent/sourceElement
Title: NavigateEvent: sourceElement property

(comment last updated: 2025-04-11 09:49:00)

domenic
domenic reviewed Apr 11, 2025
View reviewed changes
Copy link
Contributor

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

files/en-us/web/api/navigateevent/sourceelement/index.md
The initiating element can be:

- An {{htmlelement("a")}} element.
- An {{htmlelement("area")}} element.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it could also be a SVG <a> element.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers @domenic; I've added that as a possibility.

@chrisdavidmills chrisdavidmills changed the title Technical review: Document NavigateEvent.sourceElement property Editorial review: Document NavigateEvent.sourceElement property Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic left review comments

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisdavidmills @domenic