Technical review: Document <dialog> closeby attribute #39082
+182
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdavidmills
requested review from
estelle and
wbamberg
and removed request for
a team
github-actions
bot
added
Content:HTML
chrisdavidmills
changed the title
|
Preview URLs
Flaws (18)URL:
URL:
URL:
|
mfreed7
reviewed
Apr 14, 2025
|
|
||
| - `none` | ||
|
|
||
| - : No user actions can be used to close the `<dialog>` element, only developer-specified mechanisms such as a JavaScript-powered "Close" {{htmlelement("button")}} or a {{htmlelement("form")}} submission. |
There was a problem hiding this comment.
It might be helpful to add a few more bits here. Something like "e.g. <button onclick="dialog.close()">". As I read this sentence, it sounded like there was some magic declarative way to make a button close the dialog.
|
|
||
| - `any` | ||
|
|
||
| - : The `<dialog>` element can be closed via relevant platform-specific close requests, or by pressing outside the `<dialog>`. This is equivalent to the ["light dismiss" behavior of "auto" state popovers](/en-US/docs/Web/API/Popover_API/Using#auto_state_and_light_dismiss). |
There was a problem hiding this comment.
The word "pressing" is weird. Perhaps "clicking or tapping"?
|
|
||
| ## Examples | ||
|
|
||
| ```js |
There was a problem hiding this comment.
Would an HTML example be good to include, perhaps first? <dialog closedby=any>?
|
|
||
| - `none` | ||
|
|
||
| - : No user actions can be used to close the `<dialog>` element, only developer-specified mechanisms such as a JavaScript-powered "Close" {{htmlelement("button")}} or a {{htmlelement("form")}} submission. |
There was a problem hiding this comment.
Same comments as above here and below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chrome 134 supports the
closedbyattribute of the<dialog>element: see https://chromestatus.com/feature/5097714453577728.This PR documents the new attribute, plus the equivalent DOM property.
Motivation
Additional details
Related issues and pull requests