Skip to content

Fix HTML syntax errors #39099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 14, 2025
Merged

Fix HTML syntax errors #39099

merged 3 commits into from
Apr 14, 2025
+444 −356

Conversation

Josh-Cena
Copy link
Member

Fix all invalid HTML

@Josh-Cena Josh-Cena requested review from a team as code owners April 12, 2025 22:50
@Josh-Cena Josh-Cena requested review from hamishwillee, estelle, wbamberg and dipikabh and removed request for a team April 12, 2025 22:50
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs Content:Learn Learning area docs Content:Other Any docs not covered by another "Content:" label Content:HTTP HTTP docs Content:Accessibility Accessibility docs Content:SVG SVG docs Content:Firefox Content in the Mozilla/Firefox subtree size/l [PR only] 501-1000 LoC changed labels Apr 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 12, 2025 •
edited
Loading

Preview URLs (40 pages)
Flaws (205)

Note! 14 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Learn_web_development/Core/CSS_layout/Multiple-column_Layout
Title: Multiple-column layout
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/div which is a redirect

URL: /en-US/docs/Learn_web_development/Core/Structuring_content/HTML_forms
Title: Forms and buttons in HTML
Flaw count: 25

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/button which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/form which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/label which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect
    • and 20 more flaws omitted

URL: /en-US/docs/Mozilla/Firefox/Releases/1.5/Using_Firefox_1.5_caching
Title: Using Firefox 1.5 caching
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/iframe which is a redirect

URL: /en-US/docs/Related/IMSC/Using_the_imscJS_polyfill
Title: Using the imscJS polyfill
Flaw count: 4

  • broken_links:
    • /en-US/docs/Related/IMSC/ is a redirect
  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/div which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/track which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/video which is a redirect

URL: /en-US/docs/Web/Accessibility/ARIA/Reference/Roles/menuitemcheckbox_role
Title: ARIA: menuitemcheckbox role
Flaw count: 4

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/fieldset which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/hr which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/label which is a redirect

URL: /en-US/docs/Web/Accessibility/ARIA/Reference/Roles/menuitemradio_role
Title: ARIA: menuitemradio role
Flaw count: 4

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/fieldset which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/hr which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/label which is a redirect

URL: /en-US/docs/Web/Accessibility/ARIA/Reference/Roles/scrollbar_role
Title: ARIA: scrollbar role
Flaw count: 9

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/iframe which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/object which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/label which is a redirect
    • and 4 more flaws omitted

URL: /en-US/docs/Web/API/CSS_Typed_OM_API/Guide
Title: Using the CSS Typed Object Model
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/p which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/a which is a redirect

URL: /en-US/docs/Web/API/DOMImplementation/createHTMLDocument
Title: DOMImplementation: createHTMLDocument() method
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/iframe which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/title which is a redirect

URL: /en-US/docs/Web/API/HTMLAreaElement/referrerPolicy
Title: HTMLAreaElement: referrerPolicy property
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/area which is a redirect

URL: /en-US/docs/Web/API/HTMLImageElement/x
Title: HTMLImageElement: x property
Flaw count: 11

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/img which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/col which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/colgroup which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/img which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/html which is a redirect
    • and 6 more flaws omitted

URL: /en-US/docs/Web/API/HTMLInputElement/list
Title: HTMLInputElement: list property
Flaw count: 3

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/datalist which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/option which is a redirect

URL: /en-US/docs/Web/API/HTMLInputElement/reportValidity
Title: HTMLInputElement: reportValidity() method
Flaw count: 3

  • macros:
    • Macro produces link /en-US/docs/Web/API/HTMLElement/invalid_event which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/form which is a redirect

URL: /en-US/docs/Web/API/HTMLOptionElement/disabled
Title: HTMLOptionElement: disabled property
Flaw count: 5

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/option which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/optgroup which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/option which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/select which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/optgroup which is a redirect

URL: /en-US/docs/Web/API/HTMLTextAreaElement/maxLength
Title: HTMLTextAreaElement: maxLength property
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/textarea which is a redirect

URL: /en-US/docs/Web/API/HTMLTextAreaElement/minLength
Title: HTMLTextAreaElement: minLength property
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/textarea which is a redirect

URL: /en-US/docs/Web/API/Web_Audio_API/Controlling_multiple_parameters_with_ConstantSourceNode
Title: Controlling multiple parameters with ConstantSourceNode
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/API/Web_Audio_API/Tools which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect

URL: /en-US/docs/Web/API/Web_Audio_API/Simple_synth
Title: Example and tutorial: Simple synth keyboard
Flaw count: 9

  • macros:
    • Macro produces link /en-US/docs/Web/API/Web_Audio_API/Tools which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/div which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/div which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/input which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/datalist which is a redirect
    • and 4 more flaws omitted

URL: /en-US/docs/Web/API/Window/devicePixelRatio
Title: Window: devicePixelRatio property
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/canvas which is a redirect

URL: /en-US/docs/Web/CSS/content
Title: content
Flaw count: 16

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/declaration-value
    • Can't resolve /en-US/docs/Web/CSS/counter-name
    • Can't resolve /en-US/docs/Web/CSS/counter-name
    • Can't resolve /en-US/docs/Web/CSS/ident-token
    • Can't resolve /en-US/docs/Web/CSS/ident-token
    • and 6 more flaws omitted
  • macros:
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/computed_value which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/q which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/li which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/ol which is a redirect

URL: /en-US/docs/Web/CSS/line-style
Title: <line-style>
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/div which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/div which is a redirect

URL: /en-US/docs/Web/CSS/offset-path
Title: offset-path
Flaw count: 6

  • broken_links:
    • /en-US/docs/Web/CSS/CSS_positioned_layout/Understanding_z-index/Stacking_context is a redirect
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
    • Can't resolve /en-US/docs/Web/CSS/url-token
    • Can't resolve /en-US/docs/Web/CSS/url-modifier
  • macros:
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/computed_value which is a redirect

URL: /en-US/docs/Web/CSS/text-emphasis-position
Title: text-emphasis-position
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/computed_value which is a redirect

URL: /en-US/docs/Web/HTML/Reference/Elements/rtc
Title: <rtc>: The Ruby Text Container element
Flaw count: 12

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/rb which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/ruby which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/rb which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/rt which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/rt which is a redirect
    • and 7 more flaws omitted

URL: /en-US/docs/Web/HTML/Reference/Elements/table
Title: <table>: The Table element
Flaw count: 71

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/th which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/td which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/thead which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/tbody which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/tfoot which is a redirect
    • and 66 more flaws omitted

URL: /en-US/docs/Web/HTTP/Reference/Headers/Content-Security-Policy/object-src
Title: CSP: object-src
Flaw count: 7

  • macros:
    • Macro produces link /en-US/docs/Web/HTML/Element/object which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/embed which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/object which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/embed which is a redirect
    • Macro produces link /en-US/docs/Web/HTML/Element/object which is a redirect
    • and 1 more flaws omitted
  • unknown:
    • No generic content config found

(comment last updated: 2025-04-14 20:08:07)

@sideshowbarker sideshowbarker removed the request for review from a team April 13, 2025 05:01
@dipikabh dipikabh removed request for a team April 14, 2025 17:55
dipikabh
dipikabh approved these changes Apr 14, 2025
View reviewed changes
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending these fixes 🙌

Left a couple of comments for you to take another look.

files/en-us/web/css/line-style/index.md Outdated
@@ -71,7 +71,7 @@ This example uses multiple {{HTMLElement( "div" )}} elements, each with a class

```html
<div class="<line-style>">
<p><line-style></p>
<p>&lt;line-style></p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original is correct

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original is invalid HTML because line-style is not a valid element, and certainly not a void element.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course, yes! It's not an html element

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but it would be a syntax error if read as HTML code 😄 Generally we prefer actually syntactically valid code even if it's meant to be pseudocode.

files/en-us/web/css/ray/index.md Outdated
Comment on lines 299 to 300
offset-rotate: 0deg;</pre
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the closing tag can be moved to newline

@Josh-Cena Josh-Cena merged commit 874ad29 into mdn:main Apr 14, 2025
8 checks passed
@Josh-Cena Josh-Cena deleted the fix-html branch April 14, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipikabh dipikabh dipikabh approved these changes

Assignees
No one assigned
Labels
Content:Accessibility Accessibility docs Content:CSS Cascading Style Sheets docs Content:Firefox Content in the Mozilla/Firefox subtree Content:HTML Hypertext Markup Language docs Content:HTTP HTTP docs Content:Learn Learning area docs Content:Other Any docs not covered by another "Content:" label Content:SVG SVG docs Content:WebAPI Web API docs size/l [PR only] 501-1000 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Josh-Cena @dipikabh