Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update link to disabled attr in living standard #6518

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Update link to disabled attr in living standard #6518

merged 1 commit into from
Jul 2, 2021

Conversation

36degrees
Copy link
Contributor

The current link (https://html.spec.whatwg.org/multipage/forms.html#attr-input-disabled) does not point to an anchor that exists on the page. The term 'disabled' does not appear within forms.html at all.

I think the correct destination should be https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#attr-fe-disabled.

I think this has been incorrect since the multipage splitting was changed in whatwg/html#2552 when forms.html was split up and form-control-infrastructure.html was introduced.

@36degrees
Update link to disabled attr in living standard
2f65c64 
The current link (https://html.spec.whatwg.org/multipage/forms.html#attr-input-disabled) does not point to an anchor that exists on the page. The term 'disabled' does not appear within `forms.html` at all.

I think the correct destination should be https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#attr-fe-disabled.

I think this has been incorrect since the multipage splitting was changed in whatwg/html#2552 when `forms.html` was split up and `form-control-infrastructure.html` was introduced.
@36degrees 36degrees requested a review from a team as a code owner July 2, 2021 09:02
@36degrees 36degrees requested review from ericwbailey and removed request for a team July 2, 2021 09:02
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2021

Preview URLs

Flaws

URL: /en-US/docs/Web/HTML/Attributes/disabled
Title: disabled
on GitHub
Flaw count: 2

  • broken_links:
    • Can't resolve /en-US/docs/Web/HTML/Attribute/autocomplete
  • bad_bcd_queries:
    • No BCD data for query: html.elements.attributes.disabled

External URLs

URL: /en-US/docs/Web/HTML/Attributes/disabled
Title: disabled
on GitHub

No new external URLs

ericwbailey
ericwbailey approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@ericwbailey ericwbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, and congratulations on your first MDN contribution 🎉

@ericwbailey ericwbailey merged commit 7de600e into mdn:main Jul 2, 2021
@36degrees 36degrees deleted the patch-1 branch July 5, 2021 08:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericwbailey ericwbailey ericwbailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@36degrees @ericwbailey