style: observatory styling #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feedback and faq isons to be of the same size/view box. unified css filed for landing and results page.
caugner
reviewed
Mar 27, 2025
|
bdf7799 was deployed to: https://fred-pr16.review.mdn.allizom.net/ |
|
@argl I took a quick look at the deployment, and noticed that the font sizes in the top menu changed as side-effect of these Observatory styling changes. Are you intentional changing the global font sizes? |
|
@caugner I did bring over some font/text related css from the old frontend, like h1-h6 typography. I think that is what changed? Otherwise any changes down in observatory should never have any effect on the rest of the site. I needed some baseline typography to build on, that is the reason why I brought it over. |
caugner
reviewed
Apr 9, 2025
Comment on lines
+2
to
+34
| <svg | ||
| width="20" | ||
| height="22" | ||
| viewBox="0 0 20 22" | ||
| fill="none" | ||
| version="1.1" | ||
| id="svg1" | ||
| sodipodi:docname="feedback.svg" | ||
| inkscape:version="1.3.2 (091e20e, 2023-11-25)" | ||
| xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape" | ||
| xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| xmlns:svg="http://www.w3.org/2000/svg"> | ||
| <defs | ||
| id="defs1" /> | ||
| <sodipodi:namedview | ||
| id="namedview1" | ||
| pagecolor="#ffffff" | ||
| bordercolor="#000000" | ||
| borderopacity="0.25" | ||
| inkscape:showpageshadow="2" | ||
| inkscape:pageopacity="0.0" | ||
| inkscape:pagecheckerboard="0" | ||
| inkscape:deskcolor="#d1d1d1" | ||
| inkscape:zoom="51.590909" | ||
| inkscape:cx="10.001762" | ||
| inkscape:cy="11" | ||
| inkscape:window-width="2048" | ||
| inkscape:window-height="1306" | ||
| inkscape:window-x="129" | ||
| inkscape:window-y="51" | ||
| inkscape:window-maximized="0" | ||
| inkscape:current-layer="svg1" /> |
There was a problem hiding this comment.
Some inkscape attributes got inside here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Observatory styling
Motivation
frontend