-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
230 - Removing simprints #241
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mariano Ruiz <[email protected]>
Co-authored-by: Mariano Ruiz <[email protected]>
…me from tasks and output binary names
…ic/medic-android into 189-handle-location-permission � Conflicts: � src/main/java/org/medicmobile/webapp/mobile/EmbeddedBrowserActivity.java
…189-handle-location-permission
…169-remove-android-4-support
…ic/medic-android into 189-handle-location-permission
…Android 12 which we still need to build support
…edic/medic-android into 230-bye-simprints
5 tasks
Hi @jkuester, can you please have a look? Thanks! |
jkuester
requested changes
Jan 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Couple minor suggestions inline.
src/main/java/org/medicmobile/webapp/mobile/EmbeddedBrowserActivity.java
Outdated
Show resolved
Hide resolved
@jkuester thanks for the feedback! I've uploaded the requested changes :) |
jkuester
requested changes
Jan 11, 2022
src/main/java/org/medicmobile/webapp/mobile/EmbeddedBrowserActivity.java
Outdated
Show resolved
Hide resolved
jkuester
approved these changes
Jan 11, 2022
Closed
…230-bye-simprints � Conflicts: � build.gradle � gradle.properties � src/main/java/org/medicmobile/webapp/mobile/EmbeddedBrowserActivity.java � src/test/java/org/medicmobile/webapp/mobile/EmbeddedBrowserActivityTest.java
melema120
pushed a commit
to livinggoods/medic-android
that referenced
this pull request
Apr 27, 2022
Ticket: medic#230 This commit removes Simprints integration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes Simprints integration.
Ticket:
#230
PR CHT-Core:
medic/cht-core#7461
PR CHT-Docs:
medic/cht-docs#598
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.