Direct nginx logs to stdout/stderr - #111
Conversation
|
Skipping CI for Draft Pull Request. |
The nginx console plugin writes nothing to stdout/stderr by default, failing the certsuite container logging best practice test. Configure access_log and error_log to write to /dev/stdout and /dev/stderr respectively so container logs are accessible via the Kubernetes logging API. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6c1c36a to
88f498d
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesNginx logging
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Can you approve again @abrugaro ? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abrugaro, razo7 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Why we need this PR
The nginx console plugin writes nothing to stdout/stderr by default, failing the certsuite container logging best practice test (RHWA-987). Containers must emit logs to standard streams for Kubernetes log collection to work.
Changes made
Added
access_log /dev/stdout;anderror_log /dev/stderr warn;directives to the nginx server block indefault.conf.How to test
kubectl logsRelated