Skip to content

Add NetworkPolicy RBAC perms to CSV - #329

Closed
eemcmullan wants to merge 1 commit into
medik8s:mainfrom
eemcmullan:csv-rbac
Closed

Add NetworkPolicy RBAC perms to CSV#329
eemcmullan wants to merge 1 commit into
medik8s:mainfrom
eemcmullan:csv-rbac

Conversation

@eemcmullan

Copy link
Copy Markdown

Added NetworkPolicy RBAC to operator CSV for create, delete, and update.

Signed-off-by: Emily McMullan <emcmulla@redhat.com>
@openshift-ci
openshift-ci Bot requested review from jmontleon and slintes July 28, 2026 18:56
@openshift-ci

openshift-ci Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eemcmullan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5e6cbe5c-05c9-438b-b376-f05763eee351

📥 Commits

Reviewing files that changed from the base of the PR and between 08359bb and 2d06065.

📒 Files selected for processing (4)
  • bundle/manifests/self-node-remediation.clusterserviceversion.yaml
  • config/manifests/bases/self-node-remediation.clusterserviceversion.yaml
  • config/rbac/role.yaml
  • internal/controller/selfnoderemediationconfig_controller.go

📝 Walkthrough

Summary by CodeRabbit

  • Enhancements
    • Improved network policy management capabilities for node remediation operations.
    • The operator can now create, update, and delete applicable Kubernetes network policies.

Walkthrough

The controller RBAC declaration, manager ClusterRole, and ClusterServiceVersion manifests now grant create, delete, and update permissions for networking.k8s.io networkpolicies.

Changes

NetworkPolicy RBAC

Layer / File(s) Summary
Controller RBAC declarations
internal/controller/selfnoderemediationconfig_controller.go, config/rbac/role.yaml
The controller RBAC marker and manager ClusterRole add create, delete, and update access to networkpolicies.
CSV permission wiring
config/manifests/bases/self-node-remediation.clusterserviceversion.yaml, bundle/manifests/self-node-remediation.clusterserviceversion.yaml
The base and bundled ClusterServiceVersion manifests add matching cluster permissions for the controller service account.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: slintes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: adding NetworkPolicy RBAC permissions to the CSV.
Description check ✅ Passed The description is directly related to the change and accurately states the added NetworkPolicy RBAC permissions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@razo7

razo7 commented Jul 29, 2026

Copy link
Copy Markdown
Member

fyi: I feel like it duplicates #323

@eemcmullan

Copy link
Copy Markdown
Author

Closing in favor of #323

@eemcmullan eemcmullan closed this Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants