Skip to content

do not merge #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abrugaro wants to merge 2 commits into from
Closed

do not merge #94

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34a70e1
do not merge
abrugaro Aug 17, 2026
50fcaa7
Merge branch 'main' of https://github.com/abrugaro/system-tests into …
abrugaro Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions tests/nhc-operator/tests/post_deployment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,12 @@ var _ = Describe(
Expect(hasValidSubscription).To(BeTrue(),
"CSV should have operators.openshift.io/valid-subscription annotation")

By("Checking certified annotation")

_, hasCertified := annotations["operators.openshift.io/certified"]
Expect(hasCertified).To(BeTrue(),
"CSV should have operators.openshift.io/certified annotation")

By("Checking support annotation")

supportValue, hasSupport := annotations["support"]
Expand Down Expand Up @@ -205,13 +211,9 @@ var _ = Describe(
By("Checking replaces field when present")

replaces := nhcCSV.Object.Spec.Replaces
if replaces != "" {
Expect(replaces).To(ContainSubstring(nhcparams.CSVNamePattern),
"replaces field should contain %q, got %q", nhcparams.CSVNamePattern, replaces)
} else {
GinkgoWriter.Printf("CSV %q has empty spec.replaces (expected on first install)\n",
nhcCSV.Object.Name)
}
Expect(replaces).ToNot(BeEmpty(), "CSV spec.replaces should not be empty")
Expect(replaces).To(HavePrefix("node-healthcheck-operator.v99."),
"replaces field should reference v99 release, got %q", replaces)

By("Checking cluster topology for replica validation")

Expand Down Expand Up @@ -274,6 +276,11 @@ var _ = Describe(
runningPods := helpers.FilterRunningPods(nhcPods)
Expect(runningPods).ToNot(BeEmpty(), "No running NHC controller pods found")

By("Verifying NHC controller pod count matches expected minimum")

Expect(len(runningPods)).To(BeNumerically(">=", 5),
"Expected at least 5 running NHC controller pods, found %d", len(runningPods))

errorMessages := helpers.ValidateNonRootSecurityContext(
runningPods, nhcparams.ManagerContainerName, true)

Expand Down