Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove usage of "six" #396

Closed
wants to merge 3 commits into from
Closed

remove usage of "six" #396

wants to merge 3 commits into from

Conversation

a-detiste
Copy link
Contributor

meejah
meejah approved these changes Mar 12, 2024
View reviewed changes
Copy link
Owner

@meejah meejah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@meejah
Copy link
Owner

meejah commented Mar 13, 2024

hmm, looks like maybe some dependencies need to be updated for CI to pass? I'll take a look

@meejah
Copy link
Owner

meejah commented Mar 13, 2024

Hmm, how am I supposed to "edit this PR"? (i.e. it says " Maintainers are allowed to edit this pull request. ")

(I tried pushing to your remote, which I didn't really expect to work, and it didn't!)

In tox.ini I added coverage < 7.0.0 because coverage changed something and coverage-lcov doesn't work with it ....

@meejah meejah mentioned this pull request Mar 13, 2024
Merged
@a-detiste
Copy link
Contributor Author

Hmm, how am I supposed to "edit this PR"? (i.e. it says " Maintainers are allowed to edit this pull request. ")

I have no idea. I will cherry pick 964a2d9

@meejah
Copy link
Owner

meejah commented Mar 13, 2024 •
edited
Loading

I also just merged a fix to main ...
(edit:oh you're talking about that one sorry)

@coveralls
Copy link

Coverage Status

coverage: 99.689% (+0.1%) from 99.574%
when pulling c0b6dc1 on a-detiste:main
into 585d7b0 on meejah:main.

@meejah meejah mentioned this pull request Mar 13, 2024
Merged
@meejah
Copy link
Owner

meejah commented Mar 13, 2024

okay, well I can't explain why coveralls and/or GHA didn't like this when it was "your" PR ... but I merged it as #398 so thanks a lot!

@meejah meejah closed this Mar 13, 2024
@a-detiste
Copy link
Contributor Author

You're welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meejah meejah meejah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-detiste @meejah @coveralls