Skip to content

ICE: Enable TWCC feedback for audio-only connections #3674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lminiero merged 1 commit into from
Sep 23, 2026
+10 −2
Merged

ICE: Enable TWCC feedback for audio-only connections #3674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/ice.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4167,7 +4167,8 @@ static gboolean janus_ice_outgoing_transport_wide_cc_feedback(gpointer user_data
guint32 ssrc_peer = 0;
janus_ice_peerconnection_medium *medium = NULL;
if(pc) {
/* Find inbound video medium */
/* Prefer inbound video, falling back to audio if no video has a valid peer SSRC. */
janus_ice_peerconnection_medium *audio = NULL;
janus_mutex_lock(&handle->mutex);
GHashTableIter iter;
gpointer value;
Expand All @@ -4190,6 +4191,12 @@ static gboolean janus_ice_outgoing_transport_wide_cc_feedback(gpointer user_data
if(medium && ssrc_peer)
break;
}
if(audio == NULL && m && m->type == JANUS_MEDIA_AUDIO && m->recv && m->ssrc_peer[0] != 0)
audio = m;
}
if(medium == NULL && audio != NULL) {
medium = audio;
ssrc_peer = audio->ssrc_peer[0];
}
janus_mutex_unlock(&handle->mutex);
}
Expand Down Expand Up @@ -4271,7 +4278,8 @@ static gboolean janus_ice_outgoing_transport_wide_cc_feedback(gpointer user_data
medium->ssrc, ssrc_peer, feedback_packet_count, packets_to_process);
/* Enqueue it, we'll send it later */
if(len > 0) {
janus_plugin_rtcp rtcp = { .mindex = medium->mindex, .video = TRUE, .buffer = rtcpbuf, .length = len };
janus_plugin_rtcp rtcp = { .mindex = medium->mindex,
.video = (medium->type == JANUS_MEDIA_VIDEO), .buffer = rtcpbuf, .length = len };
janus_ice_relay_rtcp_internal(handle, medium, &rtcp, FALSE);
}
if(packets_to_process != packets) {
Expand Down
Loading