[codex] Harden native control QA flows#119
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef95864bc7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const guidance = cloudOnly | ||
| ? { instructionProfile: null, guidedSteps: [] } | ||
| : buildGuidedMigrationSteps(protocol, device); |
There was a problem hiding this comment.
Return explicit blocked workflow metadata
For cloud/virtual devices this now returns guidedSteps: [] and instructionProfile: null, but existing migration starters treat an empty guided-step list as a malformed plan rather than a supported block path (the iOS flow throws URLError(.cannotParseResponse) and the web flow raises a generic “could not build workflow” error after fetching the plan). This is user-visible when an unsupported device migration is attempted before the UI has fully switched to the blocked state, so the API should keep a non-executable placeholder step or provide an explicit machine-readable blocked reason that clients can render directly.
Useful? React with 👍 / 👎.
Summary
Validation