Skip to content

Bring repository in line with meilisearch-js maintenance-wise, and bump meilisearch from 0.47.0 to 0.48.2 #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Jan 22, 2025
Merged

Bring repository in line with meilisearch-js maintenance-wise, and bump meilisearch from 0.47.0 to 0.48.2 #1373

merged 35 commits into from
Jan 22, 2025

Conversation

flevi29
Copy link
Collaborator

@flevi29 flevi29 commented Jan 21, 2025 •
edited
Loading

Pull Request

There's simply too much here to properly describe. I've been at this for way too long, and I'm tired. If anything unwanted is spotted, do tell me, but I really don't wish to work on this for a while, so feel free to make changes.

I am very sorry for the amount of changes, but it would've been too much work to gradually adapt all of these things.

  • Jest -> Vitest
  • Rollup & Parcel -> Vite
  • "type": "module"
  • update meilisearch-js to latest version
  • update everything else that caused a conflict to the latest version, for the most part, and adapt code
  • other minor things, like adapting tsdoc ESLint and Prettier plugin

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 17b666a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@meilisearch/autocomplete-client Minor
@meilisearch/instant-meilisearch Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@flevi29 flevi29 mentioned this pull request Jan 21, 2025
Closed
3 tasks
@flevi29 flevi29 requested a review from Strift January 21, 2025 13:54
@flevi29 flevi29 marked this pull request as ready for review January 21, 2025 13:54
This was linked to issues Jan 21, 2025
Replace Rollup by Vite #1371
Closed
Replace Jest by Vitest #1370
Closed
Use the same dev dependencies as meilisearch-js #1368
Open
@flevi29 flevi29 changed the title Bring repository in line with meilisearch-js maintenance-wise Bring repository in line with meilisearch-js maintenance-wise, and bump meilisearch from 0.47.0 to 0.48.2 Jan 21, 2025
This was referenced Jan 21, 2025
Closed
Closed
@flevi29 flevi29 added the dependencies Improvements or additions to documentation label Jan 21, 2025
@Strift
Copy link
Collaborator

Strift commented Jan 22, 2025 •
edited
Loading

Thank you for the gigantic PR @flevi29. 🙌

This is great work. I understand everything was related, so it was hard not to update everything simultaneously. Fortunately, I just experienced working with it myself so I have a good understanding of the full context.

I'll review it today and apply any minor changes myself, if needed.

Strift
Strift reviewed Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@Strift Strift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The project is much cleaner and should be easier to maintain now.

I just noticed that in the migration from Rollup to Vite, the dependency were not marked as external anymore. Was that intended?

I updated the relevant code. Can you review it?

The rest is good for me, I will try to merge ASAP.

@flevi29
Copy link
Collaborator Author

flevi29 commented Jan 22, 2025

I just noticed that in the migration from Rollup to Vite, the dependency were not marked as external anymore. Was that intended?

I didn't really know what it will do in UMD mode, thought it wouldn't include them in the output anymore. Looks like it does though so it's fine now.

@flevi29
Copy link
Collaborator Author

flevi29 commented Jan 22, 2025

@Strift LGTM

Strift
Strift approved these changes Jan 22, 2025
View reviewed changes
Copy link
Collaborator

@Strift Strift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors meili-bors
Copy link
Contributor

meili-bors bot commented Jan 22, 2025

Build succeeded:

@meili-bors meili-bors bot merged commit 20a99b7 into meilisearch:main Jan 22, 2025
7 checks passed
This was referenced Jan 22, 2025
Closed
Closed
@flevi29 flevi29 deleted the get-in-line-with-main-repo branch January 22, 2025 07:56
@flevi29 flevi29 linked an issue Jan 22, 2025 that may be closed by this pull request
Update instant-meilisearch dependencies to use meilisearch-js v0.48 #1360
Closed
@flevi29 flevi29 mentioned this pull request Jan 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Strift Strift Strift approved these changes

Assignees
No one assigned
Labels
dependencies Improvements or additions to documentation maintenance
Projects
None yet
Milestone
No milestone
2 participants
@flevi29 @Strift