-
Notifications
You must be signed in to change notification settings - Fork 65
Update meilisearch-js
and use ESM
#1363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
meilisearch-js
and ESMmeilisearch-js
and use ESM
Okay, I narrowed down the issue to this: I still need to figure out why this causes the issue. |
@flevi29 I managed to get the playgrounds to work when using |
@Strift meilisearch/meilisearch-js#1829 should fix the remaining issue(s) 🤞 |
Superseded by #1373 |
Pull Request
Related issue
Fixes #1360
Supersedes #1362 (thanks to @flevi29 for the help)
What does this PR do?
While working on #1360, I went down the rabbit hole of making
instant-meilisearch
use ESM for TypeScript, Rollup, and Jest.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!