Update ESLint and related pacakges #1697
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flevi29
commented
Aug 21, 2024
| /** @type {import('eslint').Linter.Config[]} */ | ||
| module.exports = [ | ||
| { | ||
| ignores: ['dist/', 'tests/env/', 'coverage/', 'playgrounds/', 'docs/'], |
There was a problem hiding this comment.
This is the replacement for .eslintignore https://eslint.org/docs/latest/use/configure/migration-guide#ignoring-files
flevi29
commented
Aug 21, 2024
| rules: eslint.configs.recommended.rules, | ||
| }, | ||
| // TypeScript linting for ts files | ||
| ...tseslint.configs.recommendedTypeChecked.map((config) => ({ |
There was a problem hiding this comment.
Now TypeScript rules are also applied to test files, which wasn't the case before.
flevi29
commented
Aug 21, 2024
| @@ -53,8 +53,8 @@ | |||
| "style:fix": "yarn fmt:fix && yarn lint:fix", | |||
| "fmt": "prettier -c ./**/*.{js,ts}", | |||
| "fmt:fix": "prettier -w ./**/*.{js,ts}", | |||
| "lint": "eslint --ext .js,.ts,.tsx .", | |||
There was a problem hiding this comment.
--ext is deprecated and removed, we just include the proper files now with globs pattern.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1697 +/- ##
=======================================
Coverage 97.11% 97.11%
=======================================
Files 21 21
Lines 831 831
Branches 77 84 +7
=======================================
Hits 807 807
- Misses 23 24 +1
+ Partials 1 0 -1 ☔ View full report in Codecov by Sentry. |
flevi29
force-pushed
the
update-eslint
branch
2 times, most recently
from
c32f029
to
968b476
Compare
flevi29
force-pushed
the
update-eslint
branch
from
968b476
to
2f32001
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Why?
ESLint received major upgrade from 8 -> 9. With this comes a new flat config. Also rules have been changed a little bit.
This PR updates ESLint, related packages, and adapts config.
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!