First class testing for other ORMs #415
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No special configuration here, a basic copy/paste of the example in https://github.com/marketplace/actions/mongodb-in-github-actions
The bugfix on Mongoid is not released yet, but that should not matter since there is no real reason to turn this back to after_destroy_commit. The behavior is equivalent.
Intention is to allow testing multiple ORMs more easily, with equivalent data.
Make all models in specs generic to allow them to be easily ported to Mongoid and Sequel instead of being stuck on ActiveRecord only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
More progress toward #175 on top of #410
This PR changes the test structure in order to have testing parity between all ORMs. By the end all tests will run for each ORM with the same models. I'll write more about the rationale once I complete the full migration.