Fix chat titles relying on Anthropic key#16
Conversation
7a431b6 to
c474e11
Compare
There was a problem hiding this comment.
Additional Comments (2)
-
src/core/chorus/simpleLLM.ts, line 37 (link)logic:
params.modelis being ignored here - should useparams.modelinstead of hardcoding"claude-haiku-4-5". Callers pass"claude-3-5-sonnet-latest". -
src/core/chorus/simpleLLM.ts, line 70-78 (link)logic: Missing
max_tokensparameter - should respectparams.maxTokens.
1 file reviewed, 2 comments
c474e11 to
83f0483
Compare
There was a problem hiding this comment.
The fallback approach works, but I'm wondering if we should consider a slightly different direction.
Currently simpleLLM.ts is tightly coupled to specific providers (Anthropic, and now OpenRouter). As we add more providers, this could get unwieldy with a growing cascade of fallbacks. For example I created a PR earlier #13 to add claude code support and I'll need to update this file to get titles generation working in that case.
What do you think about creating a lightweight abstraction that picks whichever provider the user has configured?
Each provider just implements a simple method - say complete(). The existing IProvider interface is too heavy for this (streaming, tools, attachments), so a separate lightweight interface for simple completions might make sense.
Wdyt?
There was a problem hiding this comment.
Furthermore, even with the Anthropic API key configured, it fails to generate the chat names. So it's something else.
There was a problem hiding this comment.
Furthermore, even with the Anthropic API key configured, it fails to generate the chat names. So it's something else.
I think that's because it's hard-coded to use sonnet 3.5, which isn't served in the Anthropic API anymore.
There was a problem hiding this comment.
What do you think about creating a lightweight abstraction that picks whichever provider the user has configured?
This seems very reasonable 👍
…ated code. Update API calls in MessageAPI and ProjectAPI to utilize the new completion mode for summarization.
6a2a68b to
a00d419
Compare
|
Looks good 👍🏼 |
|
while trying to merge this in my fork, got what seems a very valid comment from Cursor: |
Thanks for pointing that out. Fixed 👍 |
|
Now that this and a few other PRs are merged, are there GH Actions to create a nightly build for testing? Or to automate Release bundles in GitHub? |
|
@z3ugma you can download the nightly build at https://cdn.crabnebula.app/download/chorus/chorus/latest/platform/dmg-aarch64?channel=qa. Every push to main triggers a new release. We're managing releases on CrabNebula but moving to GitHub releases at some point probably makes more sense. |
Addresses #15 by making it so that the OpenRouter API key can be used for chat title generation if an Anthropic API key is not available