Add GitHub Actions test workflow - #2
Merged
Merged
Conversation
The live source suites skip in short mode and need network plus API keys, so CI stays on the unit tests. Point make test at the same command and keep make test-live for the full suite. Co-authored-by: Melvin Lammerts <melvinsh@users.noreply.github.com>
melvinsh
marked this pull request as ready for review
August 26, 2026 09:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repo has unit tests but the only workflow was
release.yml(GoReleaser on tags). This adds.github/workflows/test.ymlso every push tomainand every PR runs:go test -short -race ./...go build ./cmd/subfaster-shortskips the live source suites inpkg/passive(TestSourcesWithoutKeys/TestSourcesWithKeys). Those need the network and API keys and already skip in short mode because they flake.make testnow matches CI (-short).make test-liveruns the full suite.Test plan
go test -short -race ./...passedtestworkflow on this PR is green