-
Notifications
You must be signed in to change notification settings - Fork 758
Add domain models and review OQL documentation #9914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
MarkvanMents
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First shot at adding a domain model and doing a quick review.
content/en/docs/refguide/modeling/domain-model/oql/oql-expression-syntax.md
Show resolved
Hide resolved
content/en/docs/refguide/modeling/domain-model/oql/oql-expression-syntax.md
Show resolved
Hide resolved
static/attachments/refguide/modeling/domain-model/oql/oql-clauses-domain-model.png
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Customer entity is mostly defined with LastName/FirstName in the examples. Only a few examples on Line 789 breaks that an includes Age and TotalOrderAmount. Perhaps let's rename the entity there to something else like CustomerInfo and use it in the COALESCE examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated this in bbefcea
|
@pijuskri |
No description provided.