[WC-3039] Fix combobox validation connection to input #1905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HedwigAR
changed the title
HedwigAR
force-pushed
the
WC-3039/fix-combobox-validation-connection-to-input
branch
from
e4788a9 to
fe2fb32
Compare
gjulivan
reviewed
Sep 23, 2025
gjulivan
reviewed
Sep 23, 2025
gjulivan
reviewed
Sep 23, 2025
packages/pluggableWidgets/combobox-web/src/components/ComboboxWrapper.tsx
Outdated
Show resolved
Hide resolved
gjulivan
reviewed
Sep 23, 2025
packages/pluggableWidgets/combobox-web/src/components/MultiSelection/MultiSelection.tsx
Outdated
Show resolved
Hide resolved
gjulivan
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Bug fix (non-breaking change which fixes an issue)
Description
Currently in the combobox the validation field and input field are not programatically connected. This means that while you can visually see that there's an error, someone using a screenreader might not get to hear this error. To fix this I added a aria-describedby that appears when there is validation info, and aria-invalid which is set to true when there is a validation message.
What should be covered while testing?