Feature 456 user list assigned projects #3586
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lorriborri
commented
Nov 5, 2024
lorriborri
commented
- closes Usecase: lists projects with data #456
- tests need to be adjusted - not working rn
- added unit tests for service
- renamed classes - use Boolean instead of Primitive
- renamed classes - use Boolean instead of Primitive
hamidonos
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Good work but there are some findings that need to be looked at
- You are missing the license header in many classes
- Think about using AssertJ "assertThat(...).is(...)" for testing. It has a fluent API and is generally better for testing in my opinion
- Simple POJO constructs like entities don't require mocking in my opinion. This will make the test setup much more complex with no real benefit. Just initialize the object right away with some default values.
- Your test cases could be more readable. I'd suggest to take a look at the interface
ArgumentsProviderwhere you initialize the desired user objects and projects directly with the right values. The methodsetUpTestCasedoes to much in my opinion.
.../src/main/java/com/mercedesbenz/sechub/domain/administration/AdministrationAPIConstants.java
Outdated
Show resolved
Hide resolved
...tration/src/main/java/com/mercedesbenz/sechub/domain/administration/project/ProjectData.java
Show resolved
Hide resolved
...tration/src/main/java/com/mercedesbenz/sechub/domain/administration/project/ProjectData.java
Show resolved
Hide resolved
...tration/src/main/java/com/mercedesbenz/sechub/domain/administration/project/ProjectData.java
Outdated
Show resolved
Hide resolved
...c/main/java/com/mercedesbenz/sechub/domain/administration/project/ProjectRestController.java
Outdated
Show resolved
Hide resolved
...tion/src/main/java/com/mercedesbenz/sechub/domain/administration/project/ProjectService.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/mercedesbenz/sechub/domain/administration/project/ProjectServiceTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/com/mercedesbenz/sechub/domain/administration/project/ProjectServiceTest.java
Outdated
Show resolved
Hide resolved
...tration/src/main/java/com/mercedesbenz/sechub/domain/administration/project/ProjectData.java
Show resolved
Hide resolved
...tion/src/main/java/com/mercedesbenz/sechub/domain/administration/project/ProjectService.java
Outdated
Show resolved
Hide resolved
lorriborri
force-pushed
the
feature-456-user-list-projects
branch
from
73c7adb
to
f5b5e33
Compare
lorriborri
changed the title
lorriborri
changed the title
hamidonos
approved these changes
Nov 12, 2024
| private String projectId; | ||
| private String owner; | ||
| private Boolean isOwned; | ||
| @JsonInclude(JsonInclude.Include.NON_NULL) |
There was a problem hiding this comment.
here you put the annotation on the field while you put the other annotations on the getters
while both approaches work I would not mix them unless there is a reason to
consider putting all annotations on one level (either field or getter)
| @@ -23,6 +23,7 @@ public class SecHubTestURLBuilder extends AbstractTestURLBuilder { | |||
| private static final String API_ADMIN_CONFIG = API_ADMIN + "/config"; | |||
| private static final String API_ADMIN_CONFIG_MAPPING = API_ADMIN_CONFIG + "/mapping"; | |||
| private static final String API_PROJECT = "/api/project"; | |||
| public static final String API_PROJECTS = "/api/projects"; | |||
There was a problem hiding this comment.
did you mean to make this public?
all other constants are private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.