Fix hex_ant and hex_snowflake: migrate to Mesa 3.x visualization API#377
Closed
Harshini2411 wants to merge 4 commits intomesa:mainfrom
Closed
Fix hex_ant and hex_snowflake: migrate to Mesa 3.x visualization API#377Harshini2411 wants to merge 4 commits intomesa:mainfrom
Harshini2411 wants to merge 4 commits intomesa:mainfrom
Conversation
for more information, see https://pre-commit.ci
- Renamed server.py to app.py with SolaraViz implementation - Updated run.py to import from app.py - Deleted portrayal.py (replaced by agent_portrayal in app.py) Fixes mesa#358
for more information, see https://pre-commit.ci
Harshini2411
changed the title
Author
Member
|
Thanks for the PR. Are you part of GSoC? |
Author
|
Hi @EwoutH , I'm currently working on my GSoC proposal for Mesa and this PR is part of my contributions to the project. |
Member
|
Cool, please do a self-review and request a peer review. |
Author
|
Closing this PR in favour of #380 which includes the correct fixes for hex_ant and hex_snowflake using proper nested package structure, along with shape_example and charts migrations. All examples tested locally and working. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #357
Partially addresses #358 (hex_snowflake only)
Changes
hex_ant (Fixes #357)
from .agent import Antto absoluteimport
from agent import Antin model.pyhex_snowflake (Partially addresses #358)
Testing