Skip to content

Add metadata forest fire#423

Open
Vanya-kapoor wants to merge 1 commit intomesa:mainfrom
Vanya-kapoor:add-metadata-forest-fire
Open

Add metadata forest fire#423
Vanya-kapoor wants to merge 1 commit intomesa:mainfrom
Vanya-kapoor:add-metadata-forest-fire

Conversation

@Vanya-kapoor
Copy link

Implements the metadata standard agreed upon in #327

Adds metadata.toml to the forest_fire example with all required fields:
title, abstract, authors, domain, space, time, complexity, keywords, and
mesa version compatibility.

This serves as the reference implementation for the metadata standard
that will be applied to all examples.

Related: #3272
@jackiekazil @EwoutH @quaquel

@codebreaker32
Copy link
Collaborator

  1. clean your git history
  2. Fix your description by explicitly mentioning the correct discussion
  3. I don't think there has been yet a consensus

Adds metadata.toml with title, abstract, authors, domain,
space, time, complexity, keywords and mesa version compatibility.

Serves as reference implementation for the metadata standard.
@Vanya-kapoor Vanya-kapoor force-pushed the add-metadata-forest-fire branch from 7d33948 to 6a77744 Compare March 21, 2026 19:18
Copy link

@himanksingh2024-svg himanksingh2024-svg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out the branch and ran solara run app.py locally — the forest fire visualization loads correctly, controls (Step, Play, Reset, Tree density slider) all work as expected.
On metadata.toml: Fields are comprehensive and well-structured. Note: Ewout has since proposed README frontmatter in #417 as the preferred direction (one file instead of separate metadata + README). Worth discussing whether to pivot to that format before this merges.
Unrelated change: The PR also modifies deffuant_weisbuch/model.py (replacing agents.to_list() with list(agents)) which is unrelated to forest_fire metadata. This should be a separate PR to keep changes focused and reviewable.
Overall the forest_fire example runs well and the metadata fields are solid. Main question is format alignment with #417.

@Vanya-kapoor
Copy link
Author

ok thanks a lot for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants