Add support for musi R1 neo

[weebl2000]

solves #1275

Continued on the work of @khudson

Build it here

[thetooth]

Looks good, no issues found.

[khudson]

I wish you would have talked to me first so we could have collaborated on this before releasing it.

Some of the fixes here were already in the works and I was adding the final polish before submitting.

Additionally, why is there a display driver specified now when the device doesn't physically have one? I specifically close the old UI to maintain user experience parity between the other single-button, no-display devices like the wismesh tag and T1000.

I have the official schematic from Muzi Works - why is there an LED controller that's not present on the board getting compiled in now?

[weebl2000]

I wish you would have talked to me first so we could have collaborated on this before releasing it.

Some of the fixes here were already in the works and I was adding the final polish before submitting.

Additionally, why is there a display driver specified now when the device doesn't physically have one? I specifically close the old UI to maintain user experience parity between the other single-button, no-display devices like the wismesh tag and T1000.

I have the official schematic from Muzi Works - why is there an LED controller that's not present on the board getting compiled in now?

Hi @khudson, feel free to commit improvements to my branch! I don't have the device, so I cannot test anything lol.

Nothing is released yet. Just fix anything which I did wrong and we can get this merged 👌

[khudson]

Excuse me? What's your end game here?Why did you submit this PR if you can't test the code? Submitting untested code that does not work, adds features for hardware that isn't present on the board, and changes the behavior away from well-understood defaults is damaging to the project and the reputation of the hardware in question.

Please cancel this PR.

I will go back and submit it when the code is ready to be merged into MeshCore. If there are enhancements you wish to add to my code, please - first get the device so you can test this - then submit a pull request to my branch and I will evaluate the applicability of it before this goes live.

Scott/Ratislav/etc. please don't merge this.

[tjdownes]

Submitting untested code that does not work, adds features for hardware that isn't present on the board, and changes the behavior away from well-understood defaults is damaging to the project and the reputation of the hardware in question.

I have to agree with @khudson. Additionally, providing links to users via the project board to allow them to build firmware from untested, untrusted resources sets a highly dangerous precedent.

Since we're discussing firmware here, shouldn't there be some sort of pipeline that tests and proves the viability and relative safety of the code? Or at least proof that tests have run and passed?

I'm no embedded systems engineer, but looking briefly, it seems relatively common practice to test and prove firmware viability

[weebl2000]

I've done a bunch of fixes for boards that I don't have myself. You really just need the datasheets, and as long as other users can verify the changes work I don't see the problem. 🤔

[recrof]

please let the original developer submit tested code. thanks.

[weebl2000]

FYI I only opened the PR after multiple people tested, so I don't think I was being reckless. Also looked at meshtastic implementation for R1 neo. See also #1275 (comment)

[recrof]

FYI I only opened the PR after multiple people tested, so I don't think I was being reckless. Also looked at meshtastic implementation for R1 neo. See also #1275 (comment)

you don't have hardware to test it on, there was already developer who is doing the work that you submitted. please don't do it this way.

[weebl2000]

I was just trying to help people get R1 neo working. I've opened PR to khudson's fork now. Main reason I opened this Pr is because their fork was based on main branch and in non working state. Not trying to steal anyone's work.

Just hope it helps some people use their R1 neo.

[thetooth]

smh. The whole reason for all this drama is because @khudson decided to do this all smoke and mirrors behind closed doors. I had to find your branch via a rumor that someone was working on the R1 and then track you down from your avatar alone. Had of @weebl2000 know of your branch and that you were sponsored by muzi to develop the firmware weebl2000 or anyone else in the community could have continued on with the work when you became unavailable and we would have had this merged a week ago for 1.14. And yet here we are 🙄

This is open source software, there's no prize for being first place, (all of you) work together so that we can better the experience for everyone instead of wasting everyone's weekend with this idiotic infighting.

[khudson]

Excuse me? No. I've been very active in the MeshCore discord, very open about what I'm doing, and available. My wife's folks came into town for a week. I didn't, "become unavailable." This isn't smoke and mirrors.

Neither of you came to me to offer help (which I would have gladly accepted) or, for that matter, said even one word to me - this just came out of the blue. This isn't about being first. This is about making sure quality, working code gets submitted. This PR contains code that doesn't work, changes behavior away from expected defaults, and compiles in modules for hardware that isn't present on the board. That's a non-starter.

I'm happy to accept help. A little communication goes a long way.