Increase MAX_FRAME_SIZE by 4 bytes#2022
Open
weebl2000 wants to merge 1 commit into
Open
Conversation
weebl2000
force-pushed
the
adjust-max-framesize
branch
from
acb8c66 to
93f25bc
Compare
Contributor
Author
|
@liamcottle thoughts? We talked about this on Discord 2 weeks ago and this seems to fix the issue without causing any problems. |
Member
I doubt there will be any issues, and it is indeed a very minimal change, but I'm hesitant to merge without it actually being tested properly due to the wide effect it will have. We already have a bunch of BLE issues, don't wanna introduce more :) |
Contributor
Author
|
I've tested on Android 16. Works fine there. Can get my hands on an iPhone later to test if needed. |
It's the safest fix for now to fix region scoped messages from being dropped early
weebl2000
force-pushed
the
adjust-max-framesize
branch
from
93f25bc to
6312ca4
Compare
|
Hello! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a region is set, transport codes add 4 bytes to the wire format. For longer flood messages (~133+ chars for 14 char username), this pushes 1-hop repeat packets past the logRxRaw() limit of MAX_FRAME_SIZE - 3 (169 bytes). The raw packet gets silently dropped, so the companion app never sees repeats and can't show "heard repeats" for those messages.
Shorter messages and messages without a region set are unaffected because they stay under the limit.
Fix: bump MAX_FRAME_SIZE from 172 to 176 (the size of the transport code field). All frame buffers and size checks reference this constant so nothing else needs to change.
Memory cost is ~1 KB worst case across all queue buffers — negligible on all platforms.
This is the easiest fix for now without dropping region scoped messages by 10-16 bytes at worst.
Confirmed this fixes it for companions. First message is 1 byte over the limit with 173 bytes, second message is at the limit with 172 bytes, third message is after flashing with this fix and stays under 176 byte limit.