Add GAT562 Mesh EVB Pro Repeater and Room Server#2042
Conversation
liamcottle
left a comment
liamcottle
left a comment
There was a problem hiding this comment.
Hey, thanks for the PR! I've submitted a few review comments on the code.
| extends = GAT562_Mesh_EVB_Pro | ||
| build_flags = | ||
| ${GAT562_Mesh_EVB_Pro.build_flags} | ||
| -D ADVERT_NAME='"GAT562 EVB Pro"' |
There was a problem hiding this comment.
usually we have Repeater suffix in default name
| -D ADVERT_LON=0.0 | ||
| -D ADMIN_PASSWORD='"password"' | ||
| -D MAX_NEIGHBOURS=50 | ||
| -D MESH_PACKET_LOGGING=1 |
There was a problem hiding this comment.
debug flags should be disabled by default
| -D ADMIN_PASSWORD='"password"' | ||
| -D MAX_NEIGHBOURS=50 | ||
| -D MESH_PACKET_LOGGING=1 | ||
| -D MESH_DEBUG=1 |
There was a problem hiding this comment.
debug flags should be disabled by default
| -D ADVERT_LON=0.0 | ||
| -D ADMIN_PASSWORD='"password"' | ||
| -D ROOM_PASSWORD='"hello"' | ||
| -D MESH_PACKET_LOGGING=1 |
There was a problem hiding this comment.
debug flags should be disabled by default
| -D ADMIN_PASSWORD='"password"' | ||
| -D ROOM_PASSWORD='"hello"' | ||
| -D MESH_PACKET_LOGGING=1 | ||
| -D MESH_DEBUG=1 |
There was a problem hiding this comment.
debug flags should be disabled by default
| -D ADVERT_LON=0.0 | ||
| -D ADMIN_PASSWORD='"password"' | ||
| -D MAX_NEIGHBOURS=50 | ||
| -D MESH_PACKET_LOGGING=1 |
There was a problem hiding this comment.
please disable logging by default
| -D ADMIN_PASSWORD='"password"' | ||
| -D MAX_NEIGHBOURS=50 | ||
| -D MESH_PACKET_LOGGING=1 | ||
| -D MESH_DEBUG=1 |
There was a problem hiding this comment.
please disable logging by default
| -D ADVERT_LON=0.0 | ||
| -D ADMIN_PASSWORD='"password"' | ||
| -D ROOM_PASSWORD='"hello"' | ||
| -D MESH_PACKET_LOGGING=1 |
There was a problem hiding this comment.
please disable logging by default
| -D ADMIN_PASSWORD='"password"' | ||
| -D ROOM_PASSWORD='"hello"' | ||
| -D MESH_PACKET_LOGGING=1 | ||
| -D MESH_DEBUG=1 |
There was a problem hiding this comment.
please disable logging by default
| ${sensor_base.build_flags} | ||
| -I variants/gat562_mesh_evb_pro | ||
| -D NRF52_POWER_MANAGEMENT | ||
| -D LORA_FREQ=475 |
There was a problem hiding this comment.
please remove LORA_FREQ, LORA_BW, LORA_SF and LORA_CR build flags as these are defined in the project root platformio.ini.
…hange Repeater name.
New commit submitted. Please review it if you're available. Thank you. |
Thank you, it looks like there's an issue where there is now 2x platformio.ini files.
I'm assuming these changes were meant to be merged into the original file? I was wondering why my original review comments were still showing up as not resolved. The other comments were about:
Are these needed? I don't think the project uses these build flags? |
I'm sorry, I overlooked the files that weren't deleted. I've submitted again. |
2 participants
This pull request introduces a new board variant for the GAT562 Mesh EVB Pro for Room Server and Repeater supported. It's a solar node so companion radio is not necessary.
