Fix Heltec V3 LoRa reset pin#2056
Conversation
|
Looking through the history, this also seems justified. The incorrect value was introduced in That makes this PR look like a straightforward board-definition correction. Heltec's published WiFi LoRa 32 V3 pin map and datasheet show Authoritative sources: |
Reimplements meshcore-dev/MeshCore PR meshcore-dev#2056 on top of 467959c for the 1.14.1 maintenance branch. References: PR: meshcore-dev#2056 Heltec ESP32 documentation index: https://docs.heltec.org/en/node/esp32/index.html Rationale: This backport changes the Heltec V3 variant from a disconnected LoRa reset line to the documented reset GPIO. The fix is limited to one platformio build flag for one target and restores hardware reset behavior without changing shared radio logic. That makes it a straightforward maintenance correction for existing Heltec V3 releases.
Summary
Why this is the right fix
Heltec's WiFi LoRa 32 V3 pin map and datasheet both document the SX1262 reset line on GPIO12 as LoRa_RST. MeshCore already passes P_LORA_RESET into the Heltec V3 radio Module constructor, so defining that pin as disconnected was inconsistent with the published hardware wiring.
Setting P_LORA_RESET to 12 matches the vendor mapping already used by the closely related Heltec V4 variant and corrects the V3 board definition without changing any other board behavior.
Authoritative sources:
Validation
Testing Firmware
This change has been built into the testing firmware at meshcore.eklhq.com. Help with testing would be appreciated.