Fix Heltec Wireless Paper battery reading#2164
Conversation
- Extract hardcoded ADC multiplier (5.42) into ADC_MULTIPLIER macro - Add ADC_MULTIPLIER=8.4 for Heltec Wireless Paper variant - Default ADC_MULTIPLIER=5.42 for Heltec V3 (unchanged behavior) Based on upstream PR meshcore-dev#2164 by Snayler
|
Where can I download a beta of this to test this out on a device? |
|
Hey, thanks for the contribution! Merging in :) |
|
@liamcottle Where can I download a firmware file for the paper to test this out? Nightly build from brazio would have it included? https://files.brazio.org/meshcore/nightly/companion/ |
Yep, have checked and the nightly files at the link you pasted include PR #2164. If you're updating from older firmware, you'll want the one without merged in the name:
If you want to erase flash and start fresh, you'll want the merged bin:
|
It's now on 1.15.0 |
3 participants
Got tired of waiting for #1584 and #1264 to fix the issues so I created this PR from the information on #1584. I decided to use @oltaco suggestion as it looks cleaner. No need to define ADC_MULTIPLIER for heltec_v3 and heltec_tracker tho, as they will use the default value.