fix: MQTT status refresh loop blocks HA startup (#225)#244
Open
RikoDEV wants to merge 1 commit into
Open
Conversation
RikoDEV
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In current implementation Home Assistant startup takes a lot of time to finalize.
_async_status_refresh_loopwas started withhass.async_create_task(), which registers the task in HA's startup tracker. Since the loop never exits (300 s sleep, runs while clients are connected), HA startup hung waiting for it on every restart.Changed to
asyncio.create_task()so the task is not tracked by HA's startup phase.async_stop()already explicitly cancels and awaits_status_refresh_taskon unload, so shutdown cleanup is unchanged.