logbook: expose hop_count and snr on incoming channel messages#245
Open
jagoda wants to merge 1 commit into
Open
Conversation
Ports the direct-message hop_count/snr exposure pattern from PR meshcore-dev#215 (handle_contact_message) to handle_channel_message. The SDK reader emits the same path_len semantics on both CONTACT_MSG_RECV and CHANNEL_MSG_RECV frames (0xFF sentinel for direct reception, otherwise literal hop count), and V3 CHANNEL_MSG_RECV frames carry SNR directly. V2 channel frames only surface SNR via the log_channels lookup, so snr is emitted only when the SDK actually populated it — matching the contact handler's behavior. docs/events.md: document hop_count (always) and snr (conditional) on the channel-message branch of meshcore_message. No firmware changes; downstream listeners already consuming hop_count/snr on direct messages can now use the same fields on channel messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the direct-message hop_count/snr exposure pattern from PR #215 (handle_contact_message) to handle_channel_message. The SDK reader emits the same path_len semantics on both CONTACT_MSG_RECV and CHANNEL_MSG_RECV frames (0xFF sentinel for direct reception, otherwise literal hop count), and V3 CHANNEL_MSG_RECV frames carry SNR directly. V2 channel frames only surface SNR via the log_channels lookup, so snr is emitted only when the SDK actually populated it — matching the contact handler's behavior.
docs/events.md: document hop_count (always) and snr (conditional) on the channel-message branch of meshcore_message.
No firmware changes; downstream listeners already consuming hop_count/snr on direct messages can now use the same fields on channel messages.