Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support writing to Meshery Broker or to file #361

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

leecalcote
Copy link
Member

@leecalcote leecalcote commented Jan 3, 2025

Signed-off-by: Lee Calcote [email protected]**

This PR fixes #355

  • Refactor ListenToRequests to write data to files instead of publishing to broker

Signed-off-by: Lee Calcote <[email protected]>

**Description**

This PR fixes #

**Notes for Reviewers**

**[Signed commits](../CONTRIBUTING.md#signing-off-on-commits-developer-certificate-of-origin)**
- [ ] Yes, I signed my commits.

<!--
Thank you for contributing to Meshery!

Contributing Conventions:

1. Include descriptive PR titles with [<component-name>] prepended.
2. Build and test your changes before submitting a PR.
3. Sign your commits

By following the community's contribution conventions upfront, the review process will
be accelerated and your PR merged more quickly.
-->
Signed-off-by: Lee Calcote <[email protected]>
@leecalcote leecalcote requested a review from devhindo January 3, 2025 03:48
@leecalcote
Copy link
Member Author

@devhindo this is an incomplete effort, but a potential start. Please carry these changes forward (or start fresh).

@leecalcote leecalcote added kind/enhancement Improvement in current feature language/go Golang related labels Jan 3, 2025
@leecalcote leecalcote changed the title leecalcote/write to file Support writing to Meshery Broker or to file Jan 3, 2025
Copy link
Member

@devhindo devhindo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lee! That really provides many insights. I'll follow up in my pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvement in current feature language/go Golang related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support one-time snapshot with MeshSync data written to local file.
2 participants