Make GPS_TX_PIN the serial TX and GPS_RX_PIN the serial RX for all NRF variants #8772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jp-bennett
approved these changes
Dec 1, 2025
aardzhanov
pushed a commit
to aardzhanov/meshtastic-firmware
that referenced
this pull request
Dec 2, 2025
8 tasks
yumibyte
added a commit
to smesh-stanford/smesh-firmware
that referenced
this pull request
Dec 7, 2025
* Add a general-purpose packet cache (#8341) * Add general-purpose packet cache This commit adds a caching system that will save packet data in a much more compact form than the regular MeshPacket protobuf. It cannot be worked with directly to the same degree (although the packet header is available), but consumes *much* less memory, and as a result can be used to temporarily store large numbers of packets. Cached packets can be retrieved either by their (from, id) tuple, or by their hash. This cache is a pre-requisite for the upcoming packet replay feature. * Remove debug initialiser Co-authored-by: Copilot <[email protected]> * Fix ordering Co-authored-by: Copilot <[email protected]> * Add missing size assignment Co-authored-by: Copilot <[email protected]> * Add comments for hash & bucket macros * Make it clear that this field stores a map of the original data --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Ben Meadors <[email protected]> * Guarding PhoneAPI node-info staging with mutex to prevent BLE future foot-gun (#8354) * Eliminating foot-gun and placing Phone NodeInfo into a mutex * Swapping over to concurrency::Lock from mutex * portduino, handle sdl2 builds (#8355) fix linux native build by adding sdl2 libraries * Log the lora frequency error when receiving a packet. (#8343) * bind python version to 3.13 (#8362) * Update actions/setup-node action to v6 (#8339) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Upgrade trunk (#8340) Co-authored-by: vidplace7 <[email protected]> * Ignore MQTT Client Proxy messages while not in sendpackets state (#8358) * Force CannedMessages to another node to be a PKI DM (#8373) * Update exempt labels for stale bot configuration Adds triaged and backlog to the list of exempt labels. * Update exempt labels for stale bot workflow Adds triaged and backlog to the list of exempt labels. * Update meshtastic/web to v2.6.7 (#8381) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fixe battery voltage to show missing decimals * Update DFRobot_RTU to v1.0.6 (#8387) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update mcr.microsoft.com/devcontainers/cpp Docker tag to v2 (#8375) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * manual merge stale bot config (#8392) * Master ---> Develop (#8391) * Update exempt labels for stale bot workflow Adds triaged and backlog to the list of exempt labels. * Update meshtastic/web to v2.6.7 (#8381) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update DFRobot_RTU to v1.0.6 (#8387) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update mcr.microsoft.com/devcontainers/cpp Docker tag to v2 (#8375) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * manual merge stale bot config (#8392) --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Board support: RAK3401+RAK13302 1-watt (#8140) * Add RAK3401 variant files * Add SPI configuration for RAK3401 and RAK13302 variants * Refactor SPI pin configuration and clean up variant definitions for RAK3401 * Add TX_GAIN_LORA for RAK13302 Power Amp * Fix merge --------- Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Tom Fifield <[email protected]> Co-authored-by: Manuel <[email protected]> * Master --> develop (#8394) * Update exempt labels for stale bot workflow Adds triaged and backlog to the list of exempt labels. * Update meshtastic/web to v2.6.7 (#8381) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update DFRobot_RTU to v1.0.6 (#8387) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update mcr.microsoft.com/devcontainers/cpp Docker tag to v2 (#8375) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * manual merge stale bot config (#8392) * Board support: RAK3401+RAK13302 1-watt (#8140) * Add RAK3401 variant files * Add SPI configuration for RAK3401 and RAK13302 variants * Refactor SPI pin configuration and clean up variant definitions for RAK3401 * Add TX_GAIN_LORA for RAK13302 Power Amp * Fix merge --------- Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Tom Fifield <[email protected]> Co-authored-by: Manuel <[email protected]> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel.Cao <[email protected]> Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Manuel <[email protected]> * Fixe battery voltage to show missing decimals (#8386) * Gatting off BaseUI code from screenless devices and InkHUD (#8384) * Update protobufs (#8396) Co-authored-by: fifieldt <[email protected]> * Clearer hop markers for inkHUD map * cleanup * trunk * Added support for SugarCube device (#8187) * Added support for SugarCube device * Update variants/esp32/sugarcube/platformio.ini Co-authored-by: Austin <[email protected]> * added buzzer pin * Apply PR comments * Fix MR comments --------- Co-authored-by: Austin <[email protected]> * Make packet pool dynamic again on STM32 as a workaround * Fix NimbleBluetooth reliability and performance (#8385) * Initial work to get NimbleBluetooth working reliably, and cross-task mutexes cleaned up * Pre-fill toPhoneQueue when safe (during config/nodeinfo): runOnceToPhoneCanPreloadNextPacket * Handle 0-byte responses breaking clients during initial config phases * requestLowerPowerConnection * PhoneAPI: onConfigStart and onConfigComplete callbacks for subclasses * NimbleBluetooth: switch to high-throughput BLE mode during config, then lower-power BLE mode for steady-state * Add some documentation to NimbleBluetooth.cpp * make cppcheck happier * Allow runOnceHandleToPhoneQueue to tell runOnce to shouldBreakAndRetryLater, so we don't busy-loop forever in runOnce * Gating some logging behind DEBUG_NIMBLE_ON_READ_TIMING ifdef again; bump retry count * Add check for connected state in NimBLE onRead() --------- Co-authored-by: Jonathan Bennett <[email protected]> * Update protobufs (#8398) Co-authored-by: thebentern <[email protected]> * NimbleBluetooth: process fromPhoneQueue before toPhoneQueue (fixes bug with 0-length reads during config phase) * NimbleBluetooth: reuse BLE_HS_CONN_HANDLE_NONE instead of creating a different constant to represent no connection * Update src/graphics/niche/InkHUD/Applets/Bases/Map/MapApplet.cpp makes sense, applying did not cause any visible issues. Co-authored-by: Copilot <[email protected]> * Update src/graphics/niche/InkHUD/Applets/Bases/Map/MapApplet.cpp better for clarity Co-authored-by: Copilot <[email protected]> * proper centering and rounder hops labels * Add a banner on startup when DEBUG_MUTE is enabled (#8402) * Remove "Phone GPS" in order to correct GPS reporting (#8407) * Removing Phone GPS reporting for the moment * Include RSSI in rangetest csv (#8395) * Include RSSI in rangetest csv * Fix typo * Preserve csv column order --------- Co-authored-by: Ben Meadors <[email protected]> * Issue: #7944 External notification module: Adjusted default nag timeout to 15s (from 60s) (#7946) * External notification module: Adjusted default nag timeout to 5s (from 60s) * Change nag to 15s --------- Co-authored-by: Tom Fifield <[email protected]> * Add support for RAK WISMESH TAP V2 by enabling SDCARD_CS pin during deep sleep (#8429) * Move airtime calculation to when Tx is complete (#8427) * Upgrade trunk (#8369) Co-authored-by: vidplace7 <[email protected]> * Don't assign negative SNR to unsigned int type SNR-based contention windows are broken on systems with 64-bit long integers. Fixes #8430 * Allow vibra or buzzer only notifications to obey cutoff (#8342) * Allow vibra or buzzer only notifications to obey cutoff * Update src/modules/ExternalNotificationModule.cpp Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Copilot <[email protected]> * InkHUD crash fix when nodes get deleted from NodeDB (#8428) * InkHUD crash fix * trunk fix * Master --> develop (#8436) * Issue: #7944 External notification module: Adjusted default nag timeout to 15s (from 60s) (#7946) * External notification module: Adjusted default nag timeout to 5s (from 60s) * Change nag to 15s --------- Co-authored-by: Tom Fifield <[email protected]> * Add support for RAK WISMESH TAP V2 by enabling SDCARD_CS pin during deep sleep (#8429) * Upgrade trunk (#8369) Co-authored-by: vidplace7 <[email protected]> * Don't assign negative SNR to unsigned int type SNR-based contention windows are broken on systems with 64-bit long integers. Fixes #8430 * Allow vibra or buzzer only notifications to obey cutoff (#8342) * Allow vibra or buzzer only notifications to obey cutoff * Update src/modules/ExternalNotificationModule.cpp Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Copilot <[email protected]> * InkHUD crash fix when nodes get deleted from NodeDB (#8428) * InkHUD crash fix * trunk fix --------- Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Onyx Clawe <[email protected]> Co-authored-by: Daniel.Cao <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: vidplace7 <[email protected]> Co-authored-by: korbinianbauer <[email protected]> Co-authored-by: Jason P <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: HarukiToreda <[email protected]> * Revert "Revert "develop --> Master" (#8244)" (#8450) This reverts commit 5bcc47dddb6aa339e51651a05ff7f2bdc6e27bd2. * Address longName wrapping (#8441) * Address longName wrapping * Update src/graphics/draw/NodeListRenderer.cpp Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Copilot <[email protected]> * Update GitHub Artifact Actions (#8443) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Migrate test workflow to use Node 24 (#8466) Node 24 is now the common version amoungst all of our actions. * Fix type to ensure correct alignment; saves 4B per entry (#8465) * Update node to v24 (#8476) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * refactor: change node count variables from uint8_t to uint16_t (#8478) This is a non-breaking change that increases the internal representation of node counts from uint8_t (max 255) to uint16_t (max 65535) to support larger mesh networks, particularly on ESP32-S3 devices with PSRAM. Changes: - NodeStatus: numOnline, numTotal, lastNumTotal (uint8_t -> uint16_t) - ProtobufModule: numOnlineNodes (uint8_t -> uint16_t) - MapApplet: loop counters changed to size_t for consistency with getNumMeshNodes() - NodeStatus: Fixed log format to use %u for unsigned integers Note: Default class methods keep uint32_t for numOnlineNodes parameter to match the public API and allow flexibility, even though internal node counts use uint16_t (max 65535 nodes). This change does NOT affect protobuf definitions, maintaining wire compatibility with existing clients and devices. * Turn the e-ink backlight on for any brightness value over 0 (#8481) * initial setup. Put the i2c sensor to be available on meshtastic. Create as5600 files for wind direction sensing * Add missed debug log line in RF95 Interface (#8490) * Thinknode M5 ADC_MULTIPLIER to actually hit 100% charge (#8489) * Refactor emote dimensions to 16x16 pixels (#8493) Updated the dimensions of various emotes in emotes.h from 30x30 or 25x25 to 16x16 pixels for consistency and optimization. Added new emotes including heart_smile, Heart_eyes, and others, all with the same 16x16 size. This change improves memory usage and aligns with the design specifications for smaller emotes. * Force stdout to be line buffered - this fixes logs ending early if meshtasticd crashes (#8499) * fix(wio-e5): Fix LED state inversion (#8500) Wio-E5 currently has LED appearing to be steadily on, due to incorrect LED_STATE_ON (it is actually briefly flashing off, but visually it is hard to perceive). Wio-E5 has LED between GPIO PB5 and VCC, so LED_STATE_ON should be 0 for LED to blink correctly. With this commit, it is now flashing correctly. Refer to schematics: * [Wio-E5 Development Kit](https://files.seeedstudio.com/products/113990934/LoRa-E5%20Dev%20Board%20v1.0.pdf) * [Wio-E5 mini](https://files.seeedstudio.com/products/113990939/LoRa-E5%20mini%20v1.0.pdf) Signed-off-by: Andrew Yong <[email protected]> * Better implementation of ExternalNotificationModule::stopNow (#8492) * Better implementation of ExternalNotificationModule::stopNow * Label external states turning off * Optimize original code to actually fix issues * Fix type to ensure correct alignment; saves 4B per entry (#8465) * Add basic LR1121 support for T-Beam S3, full support needs #4775 fixed (#8349) * adjust battery curve (#8137) Co-authored-by: HarukiToreda <[email protected]> * Add support for Bh1750 Light Sensor (#8376) * regenerate protobuf with bh1750 TelemetrySensorType * Added wollewald/BH1750_WE@^1.1.10 dependecy * Added support for BH1750 during i2C detection * Create new BH1750Sensor and added in EnvironmentTelemetry * clean code * Attempt to fix protobuf include --------- Co-authored-by: Tom Fifield <[email protected]> * Skip setting up Lora GPIO lines when using a ch341 radio on native (#8506) * Fix boot on RP2040 by excluding new FreeRTOS task (#8508) * Add IPv6 Support for esp32 (#6866) * Update Default.h * Update NodeDB.cpp * Update WiFiAPClient.cpp * Update userPrefs.jsonc * set ipv6 to off by default * Trunk fix --------- Co-authored-by: Tom Fifield <[email protected]> * Fix dismiss of ext. notification (#8512) * Dismiss all ext notifications with any input broker event * Account for nagging * Hide nodes that don't have position in the distance and bearings nodelists (#8518) * Update device-install.sh to support heltec-v4 (#8509) * Update device-install.sh * Update device-install.sh * Update device-install.sh to support heltec-v4 (#8509) * Update device-install.sh * Update device-install.sh * Add heltec v4 to bat as well * Rename screen options to display options and add units chooser (#8517) * Rename screen options to display options and add units chooser * Add InitialSelected to DisplayUnits_menu * Fix SHT4x detection by reading unique serial nubmer (#8525) * Automated version bumps (#8527) Co-authored-by: thebentern <[email protected]> * ADD - heltec v4 support to device install bat (#8528) * Add the identification code for the DA217 triaxial accelerometer. (#8526) * Revert "ADD - heltec v4 support to device install bat (#8528)" (#8532) This reverts commit 468247fb9499d2c5c36974d4a2d3712195e727f8. * fix strlcpy compile error in Ubuntu 22.04 (#8520) * fix strlcpy error in Ubuntu 20.04 * add to native after tests * Packaging: Add libbsd where needed (#8533) * nrf52: add watchdog (#8485) * nrf52: add watchdog Main thread only for now. * bump framework-arduinoadafruitnrf52 to pick up new wdt support * clang-format the new parts of main-nrf52.cpp --------- Co-authored-by: Ben Meadors <[email protected]> * Add support for RAK_WISMESH_TAP_V2 and RAK3401 hardware models (#8537) * Update RadioLib to v7.4.0 (#8456) * fix strlcpy compile error in Ubuntu 22.04 (#8520) * fix strlcpy error in Ubuntu 20.04 * add to native after tests * Add support for RAK_WISMESH_TAP_V2 and RAK3401 hardware models (#8537) * Update RadioLib to v7.4.0 --------- Co-authored-by: Manuel <[email protected]> Co-authored-by: Daniel.Cao <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Upgrade trunk (#8437) Co-authored-by: vidplace7 <[email protected]> * Update platform-native for WIFi lib fix (#8544) Updates the WiFi library way down in Portduino, to detect TCP connection drops * chore(deps): update python to v3.14.0 (#8542) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update adafruit pct2075 to v1.0.6 (#8548) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Revert "nrf52: add watchdog (#8485)" (#8554) This reverts commit 83954293d8b52068750f40ae633ae7ccaf39b9c0. * Don't Favorite Nodes if our Role is CLIENT_BASE (#8558) * Don't Favorite Nodes if our Role is CLIENT_BASE * Update CannedMessageModule.cpp * fix missing key 0 (#8564) * Store hop/mqtt/transport mechanism info in S&F (#8560) Before this, all messages received when enabling S&F server would return Hops away: -1 * Reject legacy text message DMs (#8562) Co-authored-by: Ben Meadors <[email protected]> * addFromContact: Don't auto-favorite when CLIENT_BASE; don't update last_heard unless CLIENT_BASE (#8495) Co-authored-by: Ben Meadors <[email protected]> * Update protobufs (#8566) Co-authored-by: thebentern <[email protected]> * Store hop/mqtt/transport mechanism info in S&F (#8560) Before this, all messages received when enabling S&F server would return Hops away: -1 * addFromContact: Don't auto-favorite when CLIENT_BASE; don't update last_heard unless CLIENT_BASE (#8495) Co-authored-by: Ben Meadors <[email protected]> * Persist favourites on NodeDB reset (#8292) * Conditionally delete favourited nodes on reset * trunk fmt * Fix equality check, use existing macro for role validation * Extend favourite persistence setting to devices of all roles * Refactor: Decoupled role/config check and set role defaults appropriately * Use American-English spelling * Use existing reference * Convert reset to bool, regen protos * Add optional arg to nodedb_reset in favor of additional device setting * Use correct proto commit ID * Regen protos * Log preservation status * Pull latest from master * Discard everything if downlink isn't on (#8578) * Bugfix: Don't toggle BLE when choosing active state (#8579) * Persist favourites on NodeDB reset (#8292) * Conditionally delete favourited nodes on reset * trunk fmt * Fix equality check, use existing macro for role validation * Extend favourite persistence setting to devices of all roles * Refactor: Decoupled role/config check and set role defaults appropriately * Use American-English spelling * Use existing reference * Convert reset to bool, regen protos * Add optional arg to nodedb_reset in favor of additional device setting * Use correct proto commit ID * Regen protos * Log preservation status * Pull latest from master * Discard everything if downlink isn't on (#8578) * Try-fix traceroute panic (#8568) * chore(deps): update meshtastic/device-ui digest to 28167c6 (#8583) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Upgrade trunk (#8552) Co-authored-by: vidplace7 <[email protected]> * Add API types, state, and log message in Debug screen. Added persistent "Connected" icon (#8576) * Add API types, state, and log message in Debug screen * un-goober the API state tracking * Set the SerialConsole api_type * Add api_type for Ethernet * Remove API state debugging code * Update wording for client connection states * Improve string width for smaller screen devices * Reserve space on navigation bar to fit link indicator * Add persistent Connected icon to screen * Connect System frame to ensure text doesn't overflow --------- Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Jason P <[email protected]> Co-authored-by: HarukiToreda <[email protected]> * Drop PKI acks if there is no downlink on MQTTClientProxy (#8580) * Discard everything if downlink isn't on * Drop PKI packets when downlink not on * Drop PKI acks if there is no downlink on MQTTClientProxy (#8580) * Discard everything if downlink isn't on * Drop PKI packets when downlink not on * Add the Heltec v4 expansion box. (#8539) * Add the Heltec v4 expansion box. * Change heltec-v4-oled to heltec-v4. * Add touchscreen to I2C scanning. * Add reset and busy pins to the ST7789. * Ignore the touch interrupt pin and extend the sleep time to 1 hour. * Remove the default sleep function. --------- Co-authored-by: Ben Meadors <[email protected]> * Add the Heltec v4 expansion box. (#8539) * Add the Heltec v4 expansion box. * Change heltec-v4-oled to heltec-v4. * Add touchscreen to I2C scanning. * Add reset and busy pins to the ST7789. * Ignore the touch interrupt pin and extend the sleep time to 1 hour. * Remove the default sleep function. --------- Co-authored-by: Ben Meadors <[email protected]> * Automated version bumps (#8527) Co-authored-by: thebentern <[email protected]> * Update to Pro-micro variants (#8600) * Update to Pro-micro variants Schematic updated Xtal variant removed Extra module added to list Extra explanation added to readme. * Fix markdown formatting in readme.md * Fix formatting in readme.md for RF switch section --------- Co-authored-by: Tom <[email protected]> * stm32wl: Wrap and remove some functions that pull in large amounts of code/data to claw back even more flash space (#8609) * Change RadioLib to commit zip til 7.4.1+ is released fixes regression for SX127x chips per @GUVWAF * Only call stopNow if we're nagging (#8601) * Cleanup unnecessary global dereferencing in CryptoEngine (#8611) Co-authored-by: Ben Meadors <[email protected]> * Fix null pointer dereference in radio chip region check (#8613) * Upgrade trunk (#8606) Co-authored-by: vidplace7 <[email protected]> * Clean up GPS toggle logging Removed redundant log warnings for GPS toggle events. * Automated version bumps (#8626) Co-authored-by: thebentern <[email protected]> * Feat/6704 neighbor info on demand (#8523) * full thing. works * works * minimal changes * roll back previous changes, move to using the alloc() overrride * clean up comments * format * run clang-format manually. Trunk may be the absolute worst formatter in existance * format on WSL to fix trunks awfulness * add a 3 minute cooldown to prevent messages going back and forth * add ignoring the dummy neighbor. * fix or. * fix spelling, increase logging --------- Co-authored-by: Ben Meadors <[email protected]> * Remove fixed scaling in Digital Clock (#8620) * Update digital clock draw to auto scale to correct size; no more fixed scaling * Static scale calcuation to improve performance * Update src/graphics/draw/ClockRenderer.cpp Co-authored-by: Copilot <[email protected]> * Back off for width or height exceeds * Fixes for some calcuations --------- Co-authored-by: Copilot <[email protected]> * Add code for preserving favorites, also move to Home screen before reseting (#8647) * Reset the calibration data back to 0 when doing a compass calibration * Try to look for a config file based on the HAT vendor/product for autoconfig * Address review comments * chore(deps): update dorny/test-reporter action to v2.2.0 (#8637) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Remove gating for Display Options (#8651) * Packaging: Add libbsd where needed (#8533) * Don't trust the AI! (#8659) Read the docs instead * mqtt: do not try to send packets when it disconnected (#8658) * Linux: Fix silly EPEL9 mistake (#8660) * Fix ble rssi crash (#8661) * Fix BLE crash occuring when trying to get RSSI from Android with a bad connection handle * Cleanup * mqtt: do not try to send packets when it disconnected (#8658) * If we're not client proxying and we are not connected, don't publish * Gps reset detect (#8302) * Properly format timestamp in log message * Better formatting of GPS_DEBUG logging in gps probe * Reset GPS after serial speed change, and look for magic string to identify chip * Add UC6580 to boot message detection, for Heltec Tracker * Add L76K detect from boot string, for Heltec-v4 * Slightly more useful GPS debugging * Back out detection of L76K via startup messages. * Ignore PIN_GPS_RESET = -1 and rename passive_detect array. --------- Co-authored-by: Tom Fifield <[email protected]> * Cleanup unnecessary global dereferencing in CryptoEngine (#8611) Co-authored-by: Ben Meadors <[email protected]> * Add API types, state, and log message in Debug screen. Added persistent "Connected" icon (#8576) * Add API types, state, and log message in Debug screen * un-goober the API state tracking * Set the SerialConsole api_type * Add api_type for Ethernet * Remove API state debugging code * Update wording for client connection states * Improve string width for smaller screen devices * Reserve space on navigation bar to fit link indicator * Add persistent Connected icon to screen * Connect System frame to ensure text doesn't overflow --------- Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Jason P <[email protected]> Co-authored-by: HarukiToreda <[email protected]> * Add the Heltec v4 expansion box. (#8539) * Add the Heltec v4 expansion box. * Change heltec-v4-oled to heltec-v4. * Add touchscreen to I2C scanning. * Add reset and busy pins to the ST7789. * Ignore the touch interrupt pin and extend the sleep time to 1 hour. * Remove the default sleep function. --------- Co-authored-by: Ben Meadors <[email protected]> * Update to Pro-micro variants (#8600) * Update to Pro-micro variants Schematic updated Xtal variant removed Extra module added to list Extra explanation added to readme. * Fix markdown formatting in readme.md * Fix formatting in readme.md for RF switch section --------- Co-authored-by: Tom <[email protected]> * Add code for preserving favorites, also move to Home screen before reseting (#8647) * mqtt: do not try to send packets when it disconnected (#8658) * Automated version bumps (#8626) Co-authored-by: thebentern <[email protected]> * Allow deepsleep in rak4630 and make it restart well when power comes back (#7882) * Make RAK4631 nodes power back on deep sleep The devices will hang if the VBAT goes under 1.7V (Brown-out reset) and they will never come back unless power supply goes completely off. This kills unattended nodes. Using the SystemOff the LPCOMP we can get the nodes back again when power comes back, even if VBAT goes under 1.7V, which moreover is more unlikely because the device is off. * Adding support for heltec t114 And moved particularities to variant.h * Remove old cpp comment that belongs to variant.h It was a leftover. * Trunk fix --------- Co-authored-by: Tom Fifield <[email protected]> * nrf52: add watchdog (#8485) * nrf52: add watchdog Main thread only for now. * bump framework-arduinoadafruitnrf52 to pick up new wdt support * clang-format the new parts of main-nrf52.cpp --------- Co-authored-by: Ben Meadors <[email protected]> (cherry picked from commit 83954293d8b52068750f40ae633ae7ccaf39b9c0) * nrf52 wdt: pause wdt in Sleep and Halt, set timeout to 90 s The 90 seconds wdt timeout matches the esp32 wdt timeout. * Automated version bumps (#8684) Co-authored-by: thebentern <[email protected]> * Unify uptime formatting (#8677) * Unify uptime formatting * Fix small label alignment item --------- Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Jason P <[email protected]> * CI: Submit Bump Version PR against master (#8668) * chore(deps): update meshtastic-esp8266-oled-ssd1306 digest to 2887bf4 (#8688) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * actually respect wake_on_motion setting (#8690) * Trunk fmt * Update src/graphics/draw/MenuHandler.cpp Co-authored-by: Copilot <[email protected]> * Add a reset pulse signal to the OLED. (#8691) * Add a reset pulse signal to the OLED. * The modification time is the same as that of the Adafruit_SSD1306 library. * Fix build when MESHTASTIC_EXCLUDE_PKI is defined * Fix MenuHandler when MESHTASTIC_EXCLUDE_PKI is defined * Add Thinknode M6 * fix some minor compiler warnings. Note: The 'delete' is actually safe, so we suppress the warning. * Update protobufs (#8707) Co-authored-by: caveman99 <[email protected]> * Update protobufs (#8707) Co-authored-by: caveman99 <[email protected]> * Update Kongduino-Adafruit_nRFCrypto digest to 8cde718 (#8708) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update actions/checkout action to v6 (#8695) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Add WisMesh Tag OCV array (#8646) * Add WisMesh Tag OCV array * Update 10% to 3650 --------- Co-authored-by: Jonathan Bennett <[email protected]> * R1 Neo - Added OCV_ARRAY from measured discharge curve testing + update ADC multiplier (#8716) * Added OCV_ARRAY from measured discharge curve testing and update ADC multiplier The ADC resistor divider ratio is 0.6 -> multiplier should be 1/0.6 ~=1.667 We data logged a full discharge curve at constant 100mA draw over 15hours to get a realistic voltage curve for battery SoC measurements. * Remove power.h in favor of variant.h --------- Co-authored-by: Jason P <[email protected]> Co-authored-by: Jonathan Bennett <[email protected]> * Log error if startReceive fails in LR11x0Interface (#8718) * Tweak OCV_ARRAY 100% voltage to take into account charger hysteresis and voltage sag after charge (#8720) Measured voltage of fully charged battery after a few minutes of rest * Support overriding GPS serial pins on all architectures (#8486) * Thinknode M3 support against master (#8630) * Add variant_shutdown() as a week function in main-nrf52.cpp * Add Status LED module * Add Thinknode M3 support * Catch case of BLE disabled * Update src/modules/StatusLEDModule.cpp Co-authored-by: Copilot <[email protected]> * Update src/modules/StatusLEDModule.cpp Co-authored-by: Copilot <[email protected]> * Update variants/nrf52840/ELECROW-ThinkNode-M3/rfswitch.h Co-authored-by: Copilot <[email protected]> * Remove unused pin * M3 pairing LED only active for 30 seconds after state change * Thinknode M3 shutdown work --------- Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Copilot <[email protected]> * Use LED_CHARGE and LED_PAIRING for M6 led control (#8742) * Further fix compass calibration (#8740) * Update calibration logic for ICM20948 sensor Initialize highest and lowest magnetic values based on sensor data readiness during calibration. * Refactor BMX160 calibration to use magnetometer data Update calibration logic to initialize highest and lowest values using magnetometer data. * Add missed viable defines in ::calibrate() * More quickly hide "Shutting Down" to prevent it showing on Eink sleep screen (#8749) * Swapping GPS pins for GPS TX/RX (#8751) * Reduce noise * Prevent double-registering of Rotary Encoder on TLora Pager (#8746) * Reduce noise * Prevent double registering of rotary encoder broker * Actions: Remove native from build_one (#8685) * Remove native from the build, and remove the required permissions * Delete .github/workflows/build_one_arch.yml Its borken and not really needed. one_target is the goal. * 3401 fix (#8755) * Preliminary Thinknode M4 Support * fix 3401 detection * don't push unrelated work * Add support for muzi-base (#8753) * Swap the GPS serial port pins. (#8756) * Swap the GPS serial port pins. * Trunk fixes --------- Co-authored-by: Jason P <[email protected]> Co-authored-by: Ben Meadors <[email protected]> * Fixes * More GPS pin flips for devices (#8760) * Add requestFocus() in CannedMessages (#8770) Certain actions in CannedMessages can trigger the module losing the requestFocus bit, which puts the UI into a slightly frozen state. * Upgrade trunk (#8623) Co-authored-by: vidplace7 <[email protected]> * Update Sensirion Core to v0.7.2 (#8551) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update INA226 to v0.6.5 (#8645) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update NonBlockingRTTTL to v1.4.0 (#8541) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update platformio/ststm32 to v19.4.0 (#8433) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * adding support for the ST7796 + creating a new variant of the T-beam (#6575) * remove duplicate HAS_LP5562 introduced by #6422 * add ST7796 * changes to get display centered+lib update * seperated from tbeam * forgot the simple scan case * lowered speeds to 1/4 * added SPI Speed to constructor+ cleaned up variant.h * even slower speeds.... * add ST7796 * changes to get display centered+lib update * seperated from tbeam * forgot the simple scan case * lowered speeds to 1/4 * added SPI Speed to constructor+ cleaned up variant.h * even slower speeds.... * changed variant name to tbeam-displayshield * modified variant.h and merged ini file+testing on lower spi frequency for the lora module, display shield pumps out EMI? * try higher speeds + HSPI * cleanup of redundant code * refelct changes? * trunk fmt * testing touchscreen code * further testing * changed to sensorlib 0.3.1 * i broke it , dont know how to fix at the moment will investigate * add -1 functionality for touch IRQ * revert to working example? * it works.... is pressed was not working properly * working touchscreen but gestures not moving display * swap XY+ mirror X * cleanup + addition of defines for on screen keyboard and canned message module * removed debug lines, disabled bluetooth for now because of stack smashing protect failure * reverted the revert #6640 + increased speed, bleutooth is stable now on reconnection cold booth etc , GPS is still not working though * remove debug + add fixed baudrate for gps * fmt * revert NIMble * changed display library to meshtastic org * removed baudrate of 115200 and some commented out code * Correct spelling Co-authored-by: Copilot <[email protected]> * Typo Co-authored-by: Copilot <[email protected]> * display speed x10 * resolve conflicts * undo * revert speed increase CPU * add SCREEN_TRANSITION_FRAMERATE 5 * spi speed increase of the display * using the original touchscreen implementation * removal of H file line * add USE_ST7796 to missing places * removed is pressed + interrupt * revert changes of settings.json * update to screen.cpp * test identification of CST226 and CST328 * Update src/configuration.h typo Co-authored-by: Copilot <[email protected]> * made changes to detection because it was completely wrong, CST226SE has 2 posible adresses * add merge queue * try vars * kerning in yaml. * update comment * lint etc * touching to check grandfathering * explicit ignores * add WIP for Unit C6L (#7433) * add WIP for Unit C6L * adapt to new config structure * Add c6l BLE and screen support (#7991) * Minor c6l fix * Move out of PRIVATE_HW --------- Co-authored-by: Austin <[email protected]> Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Jonathan Bennett <[email protected]> Co-authored-by: Jason P <[email protected]> Co-authored-by: Markus <[email protected]> * Update Adafruit BusIO to v1.17.3 (#8018) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update actions/checkout action to v5 (#8020) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update actions/setup-python action to v6 (#8023) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Upgrade trunk (#8025) Co-authored-by: vidplace7 <[email protected]> * Update actions/download-artifact action to v5 (#8021) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix init for InputEvent (#8015) * Automated version bumps (#8028) Co-authored-by: thebentern <[email protected]> * Allow Left / Right Events for selection and improve encoder responsives (#8016) * Allow Left / Right Events for selection and improve encoder responsives * add define for ROTARY_DELAY * T-Lora Pager: Support LR1121 and SX1280 models (#7956) * T-Lora Pager: Support LR1121 and SX1280 models * Remove ifdefs * (resubmission) Manual GitHub actions to allow building one target or arch (#7997) * Reset the modified files * Fix some changes * Fix some changes * Trunk. That is all. --------- Co-authored-by: Tom <[email protected]> * BaseUI Show/Hide Frame Functionality (#7382) * Rename System Frame (from Memory) in code base * Create menu options to Show/Hide frames: Node Lists, Bearings, Position, LoRa, Clock and Favorites frames * Move Region Picker into submenu * Tweak wording for Send Position vs Node Info if the device has GPS * Update actions/checkout action to v5 (#8031) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update actions/download-artifact action to v5 (#8032) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Update actions/setup-python action to v6 (#8033) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Phone GPS display on Position Screen for BaseUI (#7875) * Phone GPS display on Position Screen This is a PR to show when a phone shares GPS location with the node so you can reliably know what coordinate is being shared with the Mesh. * Merge pull request #8004 from compumike/compumike/debug-heap-add-free-heap-debugging-to-all-log-lines When `DEBUG_HEAP` is defined, add free heap bytes to every log line in `RedirectablePrint::log_to_serial` * Feature: Seamless Cross-Preset Communication via UDP Multicast Bridging (#7753) * Added compatibility between nodes on different Presets through `Mesh via UDP` * Optimize multicast handling and channel mapping - FloodingRouter: remove redundant UDP-encrypted rebroadcast suppression. - Router: guard multicast fallback with HAS_UDP_MULTICAST and map fallback-decoded packets to the local default channel via isDefaultChannel() - UdpMulticastHandler: set transport_mechanism only after successful decode * trunk fmt * Move setting transport mechanism. --------- Co-authored-by: GUVWAF <[email protected]> * Auto-favorite remote admin node * Merge pull request #7873 from compumike/compumike/client-base-role Add `CLIENT_BASE` role: `ROUTER` for favorites, `CLIENT` otherwise (for attic/roof nodes!) * Fixes * BaseUI Updates (#7787) * Account for low resolution wide screen OLEDs * Allow picking of Device Role and new Display Formatter for Device Role * Add remainder of client roles to display formatter * Don't update the role unless you pick a value * Mascots are fun * Fix warnings during compile time * Improve some menus * Mascots need to work everywhere * Update Chirpy image * Fix Trunk * Update protobufs * Add date to Clock screen * Analog clocks love dates too * Finalize date moves for analog clock * Added Last Coordinate counter to Position screen (#7865) Adding a counter to show the last time a GPS coordinate was detected to ensure the user is aware how long since the coordinate updated or to identify any errors. * Fix * Portduino config refactor (#7796) * Start portduino_config refactor * refactor GPIOs to new portduino_config * More portduino_config work * More conversion to portduino_config * Finish portduino_config transition * trunk * yaml output work * Simplify the GPIO config * Trunk * updated shebang to use a more standard path for bash (#7922) Signed-off-by: Trenton VanderWert <[email protected]> * Show GPS Date properly in drawCommonHeader (#7887) * Commit good code that is sustainable * Fix new build errors * BaseUI Updates (#7787) * Account for low resolution wide screen OLEDs * Allow picking of Device Role and new Display Formatter for Device Role * Add remainder of client roles to display formatter * Don't update the role unless you pick a value * Mascots are fun * Fix warnings during compile time * Improve some menus * Mascots need to work everywhere * Update Chirpy image * Fix Trunk * Update protobufs * Add date to Clock screen * Analog clocks love dates too * Finalize date moves for analog clock * Add formatting and menu picking for other GPS format options (#7974) * Add back options for other GPS format options * Rename variables and don't overlap elements * Fix default value * Should probably add a menu while I'm here! * Shorten names just a bit to fit on screens * Fix off by one * Labels try to make things better * Missed a label * Update protobufs (#8038) Co-authored-by: thebentern <[email protected]> * Add formatting and menu picking for other GPS format options (#7974) * Add back options for other GPS format options * Rename variables and don't overlap elements * Fix default value * Should probably add a menu while I'm here! * Shorten names just a bit to fit on screens * Fix off by one * Labels try to make things better * Missed a label * Add a new GPS model CM121. (#7852) * Add a new GPS model CM121. * Add CM121 to Unicore. * Trunk fixes, remove unneded NMEA lines --------- Co-authored-by: Tom Fifield <[email protected]> * (resubmission) Manual GitHub actions to allow building one target or arch (#7997) * Reset the modified files * Fix some changes * Fix some changes * Trunk. That is all. --------- Co-authored-by: Tom <[email protected]> * PPA: Enable Ubuntu 25.10 (questing) (#7940) * Update Protobuf usage, add MLS, fix clock (#8041) * Update protobufs (#8045) Co-authored-by: thebentern <[email protected]> * Fix icon * C6l fixes (#8047) * fix build with HAS_TELEMETRY 0 (#8051) * Make sure to ACK ACKs/replies if next-hop routing is used (#8052) * Make sure to ACK ACKs/replies if next-hop routing is used To stop their retransmissions; hop limit of 0 is enough * Update src/mesh/ReliableRouter.cpp Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Copilot <[email protected]> * move HTTP contentTypes to Flash - saves 768 Bytes of RAM (#8055) * Use `lora.use_preset` config to get name (#8057) * Update RadioLib to v7.3.0 (#8065) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Fix Rotary Encoder Button (#8001) this fixes the Rotary Encoder Button, currenlty its not working at all. Currently the action `ROTARY_ACTION_PRESSED` is only triggerd with a IRQ on RISING, which results in nothing since the function detects the "not longer" pressed button --> no action. the `ROTARY_ACTION_PRESSED` implementation needs to be called on both edges (on press and release of the button) changing the interupt setting to `CHANGE` fixes the problem. * Add another seeed_xiao_nrf52840_kit build environment for I2C pinout (#8036) * Update platformio.ini * Remove some more extraneous lines * Add heltec_v4 board. (#7845) * add heltec_v4 board. * Update variants/esp32s3/heltec_v4/platformio.ini Co-authored-by: Austin <[email protected]> * Limit the maximum output power. * Trunk fixes Fixes formatting to match meshtastic trunk linter. * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Austin <[email protected]> Co-authored-by: Tom Fifield <[email protected]> Co-authored-by: Copilot <[email protected]> * Upgrade trunk (#8078) Co-authored-by: vidplace7 <[email protected]> * portduino bump to fix gpiod bug (#8083) An earlier portduino causes problems with initializing gpiod lines. This pulls in the fix. * Handle ext. notification module things even if not enabled (#8089) * tlora-pager wake on button, and kb backlight toggling (#8090) * Try-fix: Unstick that PhoneAPI state (#8091) Co-authored-by: Jonathan Bennett <[email protected]> * Also pull a deviceID from esp32c6 devices (#8092) * Remove line from BLE pin screen, to make pin readible on tiny screens * Fix build errors (#8067) * Heltec V4 is 16mb * Clear lasttoradio on BLE disconnect (#8095) * On disconnect, clear the lastToRadio buffer * Move it, bucko! * Revert "Fix build errors (#8067)" This reverts commit d998f70b5633e8b2f88823cfb73761625bbc3423. * Automated version bumps (#8100) Co-authored-by: thebentern <[email protected]> * Upgrade trunk (#8094) Co-authored-by: vidplace7 <[email protected]> * Update Adafruit BusIO to v1.17.4 (#8098) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Add three expansion screens for heltec mesh solar. (#7995) * Add three expansion screens for heltec mesh solar. * delete whitespace Update variants/nrf52840/heltec_mesh_solar/variant.h Co-authored-by: Copilot <[email protected]> * delete whitespace Update variants/nrf52840/heltec_mesh_solar/platformio.ini Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Ben Meadors <[email protected]> * Trunk --------- Signed-off-by: Trenton VanderWert <[email protected]> Co-authored-by: Thomas Göttgens <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Dane Evans <[email protected]> Co-authored-by: Austin <[email protected]> Co-authored-by: Jonathan Bennett <[email protected]> Co-authored-by: Jason P <[email protected]> Co-authored-by: Markus <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: vidplace7 <[email protected]> Co-authored-by: Markus <[email protected]> Co-authored-by: thebentern <[email protected]> Co-authored-by: WillyJL <[email protected]> Co-authored-by: Tom <[email protected]> Co-authored-by: Tom <[email protected]> Co-authored-by: Jason P <[email protected]> Co-authored-by: HarukiToreda <[email protected]> Co-authored-by: Michael <[email protected]> Co-authored-by: GUVWAF <[email protected]> Co-authored-by: Trent V. <[email protected]> Co-authored-by: Quency-D <[email protected]> Co-authored-by: Tom Fifield <[email protected]> Co-authored-by: GUVWAF <[email protected]> * - Correct vertical alignment for Muzi_Base on On Screen Keyboard (#8774) * Remove screen activation in powerExit function (#8779) This seems to be a potential source of unintended screen wakes. * Upgrade trunk (#8781) Co-authored-by: vidplace7 <[email protected]> * Use the dedicated isVbusIn() function for detecting USB plug * Add LOG_POWERFSM and LOG_INPUT debug macros (#8791) * Fix ifdef statement after ST7796 merge to resolve screen color issues (#8796) * Update dorny/test-reporter action to v2.3.0 (#8809) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Replace assert in UTF8 decoder to prevent unexpected reboot (#8807) * Update meshtastic/device-ui digest to 3bf3322 (#8814) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * rework screen.cpp ifdefs (#8816) * Add WiFi Toggle to System frame to re-enable (#8802) Co-authored-by: Jonathan Bennett <[email protected]> * Modify power saving condition for WiFi (#8815) Update preprocessor directive to require both HAS_WIFI and MESHTASTIC_EXCLUDE_WIFI conditions. * Add initial support for Hackaday Communicator (#8771) * Add initial support for Hackaday Communicator * Fork it! * Trunk * Remove unused elements from the HackadayCommunicatorKeyboard * Don't divide by zero. * Enabled MQTT and WEBSERVER by default (#8679) Signed-off-by: kur1k0 <[email protected]> Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Jonathan Bennett <[email protected]> * Initial Chatter 2.0 fix for baseUI (#8615) * Initial Chatter 2.0 fix for baseUI * trunk fix --------- Co-authored-by: Jason P <[email protected]> * Make GPS_TX_PIN the serial TX and GPS_RX_PIN the serial RX for all NRF variants (#8772) * Update XPowersLib to v0.3.2 (#8823) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * Upgrade trunk (#8822) Co-authored-by: vidplace7 <[email protected]> * RPM: Fix broken builds (bad backmerge) (#8787) Co-authored-by: Ben Meadors <[email protected]> * Flags and scripts for size reduction on NRF52 -> Currently targeting … (#8825) * Flags and scripts for size reduction on NRF52 -> Currently targeting rak4631 * Changes from the other branch poluted it * Remove the stripper * No strip * Plain RAK4631 should not compile EInk and TFT display code (#8811) * Plain RAK4631 should not compile EInk and TFT display code * Add USE_TFTDISPLAY to variant files. * Derp * Undo the platformio.ini changes to heltec_v4 * Drop unneeded src_filter lines --------- Co-authored-by: Jonathan Bennett <[email protected]> Co-authored-by: Jason P <[email protected]> * Commented out the definition of BATTERY_LPCOMP_INPUT in the Helltec T114 variant, due to power leakage of 2.9mA in off state. See bug #8801 (#8800) Co-authored-by: Ben Meadors <[email protected]> * Automated version bumps (#8786) Co-authored-by: thebentern <[email protected]> * Move everything from /arch to /variant (#8831) * Move device specific OCV curves to their respective device.h (#8834) * Don't scale up the frequency of telemetry sending (#8664) --------- Signed-off-by: Andrew Yong <[email protected]> Signed-off-by: Trenton VanderWert <[email protected]> Signed-off-by: kur1k0 <[email protected]> Co-authored-by: Erayd <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Ben Meadors <[email protected]> Co-authored-by: Clive Blackledge <[email protected]> Co-authored-by: Mike Weaver <[email protected]> Co-authored-by: Jonathan Bennett <[email protected]> Co-authored-by: Paweł Czaplewski <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: vidplace7 <[email protected]> Co-authored-by: Tom Fifield <[email protected]> Co-authored-by: HarukiToreda <[email protected]> Co-authored-by: Daniel.Cao <[email protected]> Co-authored-by: Manuel <[email protected]> Co-authored-by: fifieldt <[email protected]> Co-authored-by: igorka48 <[email protected]> Co-authored-by: Austin <[email protected]> Co-authored-by: Chloe Bethel <[email protected]> Co-authored-by: Mike Robbins <[email protected]> Co-authored-by: thebentern <[email protected]> Co-authored-by: Jason P <[email protected]> Co-authored-by: Ford Jones <[email protected]> Co-authored-by: Onyx Clawe <[email protected]> Co-authored-by: GUVWAF <[email protected]> Co-authored-by: korbinianbauer <[email protected]> Co-authored-by: Ixitxachitl <[email protected]> Co-authored-by: Andrew Yong <[email protected]> Co-authored-by: Marius Faber <[email protected]> Co-authored-by: shortwavesurfer2009 <[email protected]> Co-authored-by: pa0lin082 <[email protected]> Co-authored-by: Xavier horwood <[email protected]> Co-authored-by: Melon <[email protected]> Co-authored-by: Dmitry Ivanishkin <[email protected]> Co-authored-by: Quency-D <[email protected]> Co-authored-by: Sebastian Kuzminsky <[email protected]> Co-authored-by: Wessel <[email protected]> Co-authored-by: Benjamin Faershtein <[email protected]> Co-authored-by: Tom <[email protected]> Co-authored-by: Tom <[email protected]> Co-authored-by: Thomas Göttgens <[email protected]> Co-authored-by: Jason B. Cox <[email protected]> Co-authored-by: Andrik45719 <[email protected]> Co-authored-by: Dane Evans <[email protected]> Co-authored-by: omgbebebe <[email protected]> Co-authored-by: viric <[email protected]> Co-authored-by: caveman99 <[email protected]> Co-authored-by: Avi0n <[email protected]> Co-authored-by: simon-muzi <[email protected]> Co-authored-by: Nasimovy <[email protected]> Co-authored-by: Jason P <[email protected]> Co-authored-by: Markus <[email protected]> Co-authored-by: Markus <[email protected]> Co-authored-by: WillyJL <[email protected]> Co-authored-by: Michael <[email protected]> Co-authored-by: GUVWAF <[email protected]> Co-authored-by: Trent V. <[email protected]> Co-authored-by: Riker <[email protected]> Co-authored-by: rbomze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8486 inadvertantly changed the behaviour of the GPS_TX_PIN and GPS_RX_PIN defines on non-ESP32 architectures - GPS_TX_PIN is now the serial TX pin and GPS_RX_PIN is the serial RX pin, rather than being some combination defined per variant. This was already the behaviour on ESP32 platforms.
Try to straighten it out.
🤝 Attestations